Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2212463002: Merge "arc: Use location service consent." (Closed)

Created:
4 years, 4 months ago by xiyuan
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Use location service consent." > This adds option to use location service into OptIn flow and fix > similar backup and restore consent. > > BUG=631264 > TEST=Manually on device together with Android side CL. On fresh device > go through OptIn flow and set use location service off. Start > Play Store and install Google Maps app. On start, Google Maps > asks permission to activate usage of Location service. Disable > and re-enable Arc and go throug OptIn flow but set this feature > on and repeat Google Maps installation. On start, Google maps > app does not ask permission to modify usage Location service. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2179803002 > Cr-Commit-Position: refs/heads/master@{#407650} > (cherry picked from commit 905787aa98feb38d969bcf03b0214a9d1a5a4c43)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -58 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_settings_service.cc View 12 chunks +59 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 6 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/background.js View 6 chunks +27 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/main.css View 6 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/main.html View 1 chunk +18 lines, -9 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698