Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2212403004: Include non-composited layout views in existing workaround for clipping changes. (Closed)

Created:
4 years, 4 months ago by wkorman
Modified:
4 years, 4 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include non-composited layout views in existing workaround for clipping changes. BUG=633869 Committed: https://crrev.com/74d1e73747b73764b50dfaf413344397c14b971f Cr-Commit-Position: refs/heads/master@{#410222}

Patch Set 1 #

Patch Set 2 : Don't need run-after-layout-and-paint. #

Total comments: 2

Patch Set 3 : Add test rebaseline. #

Messages

Total messages: 12 (5 generated)
wkorman
4 years, 4 months ago (2016-08-05 22:49:03 UTC) #3
chrishtr
lgtm https://codereview.chromium.org/2212403004/diff/20001/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/2212403004/diff/20001/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp#newcode410 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:410: && (hasOverflowClip() || isLayoutView())) Add a comment that ...
4 years, 4 months ago (2016-08-05 22:51:46 UTC) #4
wkorman
https://codereview.chromium.org/2212403004/diff/20001/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/2212403004/diff/20001/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp#newcode410 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:410: && (hasOverflowClip() || isLayoutView())) On 2016/08/05 at 22:51:46, chrishtr ...
4 years, 4 months ago (2016-08-05 22:57:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212403004/40001
4 years, 4 months ago (2016-08-05 22:58:09 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-06 00:15:45 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/74d1e73747b73764b50dfaf413344397c14b971f Cr-Commit-Position: refs/heads/master@{#410222}
4 years, 4 months ago (2016-08-06 00:17:12 UTC) #11
foolip
4 years, 4 months ago (2016-08-09 13:38:00 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2220423004/ by foolip@chromium.org.

The reason for reverting is: fast/repaint/resize-iframe-text.html is flaky on
Mac and Win.

BUG=635892.

Powered by Google App Engine
This is Rietveld 408576698