Fix BOM handling in TextResourceDecoder on partial data

Fix BOM handling in TextResourceDecoder on partial data

TextResourceDecoder::decode() fails to handle BOM check failure when
available chunk of the data is only few bytes.
Also, TextResourceDecoder::checkForBOM() wrongly detects little endian
UTF16 BOM as little endian UTF32 when avaibale data is only few bytes.

This CL changes decode() to defer the decoding on failure on BOM
detection, and fixes checkForBOM() for ambiguous BOM case.

BUG=634935
Committed: https://crrev.com/c792d1ca228e3fd8fc254c9a8f3a51e5e5d76832
Cr-Commit-Position: refs/heads/master@{#410283}

[tzik, 2016-08-05 15:02:12]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 15:02:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-08-05 15:03:02]

tzik@chromium.org changed reviewers:
+ kouhei@chromium.org

[tzik, 2016-08-05 15:03:03]

PTAL

[commit-bot: I haz the power, 2016-08-05 16:11:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 16:11:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kouhei (in TOK), 2016-08-06 01:16:31]

lgtm % comment. Thanks for the patch!

https://codereview.chromium.org/2212393003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2212393003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:374: if
(!m_checkedForBOM) {
Would you add a comment above why we need this double check?

[tzik, 2016-08-07 09:54:28]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 09:54:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-08-07 09:55:19]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 09:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-08-07 10:18:45]

https://codereview.chromium.org/2212393003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2212393003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:374: if
(!m_checkedForBOM) {
On 2016/08/06 01:16:31, kouhei wrote:
> Would you add a comment above why we need this double check?

Done.

[tzik, 2016-08-07 10:18:50]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2016-08-07 10:18:58]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-08-07 10:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2212393003/#ps40001
(title: "+comment")

[commit-bot: I haz the power, 2016-08-07 10:19:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 11:25:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-07 11:27:25]

Description was changed from

==========
Fix BOM handling in TextResourceDecoder on partial data

TextResourceDecoder::decode() fails to handle BOM check failure when
available chunk of the data is only few bytes.
Also, TextResourceDecoder::checkForBOM() wrongly detects little endian
UTF16 BOM as little endian UTF32 when avaibale data is only few bytes.

This CL changes decode() to defer the decoding on failure on BOM
detection, and fixes checkForBOM() for ambiguous BOM case.

BUG=634935
==========

to

==========
Fix BOM handling in TextResourceDecoder on partial data

TextResourceDecoder::decode() fails to handle BOM check failure when
available chunk of the data is only few bytes.
Also, TextResourceDecoder::checkForBOM() wrongly detects little endian
UTF16 BOM as little endian UTF32 when avaibale data is only few bytes.

This CL changes decode() to defer the decoding on failure on BOM
detection, and fixes checkForBOM() for ambiguous BOM case.

BUG=634935

Committed: https://crrev.com/c792d1ca228e3fd8fc254c9a8f3a51e5e5d76832
Cr-Commit-Position: refs/heads/master@{#410283}
==========

[commit-bot: I haz the power, 2016-08-07 11:27:26]

Patchset 3 (id:??) landed as
https://crrev.com/c792d1ca228e3fd8fc254c9a8f3a51e5e5d76832
Cr-Commit-Position: refs/heads/master@{#410283}