Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: src/parsing/rewriter.h

Issue 2212383003: Revert of Separate Scope into DeclarationScope and Scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/preparser.cc ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSING_REWRITER_H_ 5 #ifndef V8_PARSING_REWRITER_H_
6 #define V8_PARSING_REWRITER_H_ 6 #define V8_PARSING_REWRITER_H_
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
11 class AstValueFactory; 11 class AstValueFactory;
12 class DoExpression; 12 class DoExpression;
13 class ParseInfo; 13 class ParseInfo;
14 class Parser; 14 class Parser;
15 class DeclarationScope;
16 class Scope; 15 class Scope;
17 16
18 class Rewriter { 17 class Rewriter {
19 public: 18 public:
20 // Rewrite top-level code (ECMA 262 "programs") so as to conservatively 19 // Rewrite top-level code (ECMA 262 "programs") so as to conservatively
21 // include an assignment of the value of the last statement in the code to 20 // include an assignment of the value of the last statement in the code to
22 // a compiler-generated temporary variable wherever needed. 21 // a compiler-generated temporary variable wherever needed.
23 // 22 //
24 // Assumes code has been parsed and scopes have been analyzed. Mutates the 23 // Assumes code has been parsed and scopes have been analyzed. Mutates the
25 // AST, so the AST should not continue to be used in the case of failure. 24 // AST, so the AST should not continue to be used in the case of failure.
26 static bool Rewrite(ParseInfo* info); 25 static bool Rewrite(ParseInfo* info);
27 26
28 // Rewrite a list of statements, using the same rules as a top-level program, 27 // Rewrite a list of statements, using the same rules as a top-level program,
29 // to ensure identical behaviour of completion result. The temporary is added 28 // to ensure identical behaviour of completion result. The temporary is added
30 // to the closure scope of the do-expression, which matches the closure scope 29 // to the closure scope of the do-expression, which matches the closure scope
31 // of the outer scope (the do-expression itself runs in a block scope, not a 30 // of the outer scope (the do-expression itself runs in a block scope, not a
32 // closure scope). This closure scope needs to be passed in since the 31 // closure scope). This closure scope needs to be passed in since the
33 // do-expression could have dropped its own block scope. 32 // do-expression could have dropped its own block scope.
34 static bool Rewrite(Parser* parser, DeclarationScope* closure_scope, 33 static bool Rewrite(Parser* parser, Scope* closure_scope, DoExpression* expr,
35 DoExpression* expr, AstValueFactory* factory); 34 AstValueFactory* factory);
36 }; 35 };
37 36
38 37
39 } // namespace internal 38 } // namespace internal
40 } // namespace v8 39 } // namespace v8
41 40
42 #endif // V8_PARSING_REWRITER_H_ 41 #endif // V8_PARSING_REWRITER_H_
OLDNEW
« no previous file with comments | « src/parsing/preparser.cc ('k') | src/parsing/rewriter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698