Chromium Code Reviews
DescriptionReland: ImageCapture: Queue up requests while device not ready
This CL is a reland of https://crrev.com/2193213003, that got
reverted due to timeouts in a few Android bots, probably because
TakePhoto() takes too much time in these bots if done without a specific
and small resolution (which currently not implemented). Disabling these
tests FTM.
Original CL description-------------------------------------------------
ImageCapture: Queue up requests while device not ready
Calls to ImageCapture methods (e.g. takePhoto(), getPhotoCapabilities())
might be lost if racing against either:
- device creation (in VideoCaptureManager)
- actual device capture (in VideoCaptureDeviceAndroid)
So, this CL:
- adds a "queue" of image capture-related requests in
VideoCaptureManager, where we store such requests _if_ the
capture device is not ready (but it's known) -- these are
served OnDeviceStarted().
- adds a similar "queue" of requests in VideoCaptureDeviceAndroid,
where we store requests is the device has not captured anything
yet (Android API needs the device up and running for many
operations).
- adds a takePhoto() content_browsertest for Android and
FakeVideoCaptureDevice, factoring Js code appropriately.
BUG=518807, 627537
TEST=added new content_browsertest:
out/gn/bin/run_content_browsertests(_incremental) --gtest_filter=*WebRtcImageCaptureBrowserTest*
or
out/gn/content_browsertests --gtest_filter=*WebRtcImageCaptureBrowserTest*
TBR=emircan@chromium.org, ncarter@chromium.org
Committed: https://crrev.com/1eb7bf07344d04a9687dbb57980c304535021901
Cr-Commit-Position: refs/heads/master@{#410080}
Patch Set 1 : Verbatim https://codereview.chromium.org/2193213003/ #Patch Set 2 : Disable Android tests with bug and explanation #
Messages
Total messages: 11 (8 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||