Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Issue 2212343003: Reland: ImageCapture: Queue up requests while device not ready (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ImageCapture: Queue up requests while device not ready This CL is a reland of https://crrev.com/2193213003, that got reverted due to timeouts in a few Android bots, probably because TakePhoto() takes too much time in these bots if done without a specific and small resolution (which currently not implemented). Disabling these tests FTM. Original CL description------------------------------------------------- ImageCapture: Queue up requests while device not ready Calls to ImageCapture methods (e.g. takePhoto(), getPhotoCapabilities()) might be lost if racing against either: - device creation (in VideoCaptureManager) - actual device capture (in VideoCaptureDeviceAndroid) So, this CL: - adds a "queue" of image capture-related requests in VideoCaptureManager, where we store such requests _if_ the capture device is not ready (but it's known) -- these are served OnDeviceStarted(). - adds a similar "queue" of requests in VideoCaptureDeviceAndroid, where we store requests is the device has not captured anything yet (Android API needs the device up and running for many operations). - adds a takePhoto() content_browsertest for Android and FakeVideoCaptureDevice, factoring Js code appropriately. BUG=518807, 627537 TEST=added new content_browsertest: out/gn/bin/run_content_browsertests(_incremental) --gtest_filter=*WebRtcImageCaptureBrowserTest* or out/gn/content_browsertests --gtest_filter=*WebRtcImageCaptureBrowserTest* TBR=emircan@chromium.org, ncarter@chromium.org Committed: https://crrev.com/1eb7bf07344d04a9687dbb57980c304535021901 Cr-Commit-Position: refs/heads/master@{#410080}

Patch Set 1 : Verbatim https://codereview.chromium.org/2193213003/ #

Patch Set 2 : Disable Android tests with bug and explanation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -160 lines) Patch
M content/browser/renderer_host/media/video_capture_manager.h View 4 chunks +21 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 6 chunks +87 lines, -29 lines 0 comments Download
M content/browser/webrtc/webrtc_image_capture_browsertest.cc View 1 3 chunks +37 lines, -16 lines 0 comments Download
M content/test/data/media/image_capture_test.html View 3 chunks +56 lines, -16 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.h View 4 chunks +24 lines, -8 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 9 chunks +169 lines, -83 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212343003/20001
4 years, 4 months ago (2016-08-05 16:36:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 16:40:33 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:41:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1eb7bf07344d04a9687dbb57980c304535021901
Cr-Commit-Position: refs/heads/master@{#410080}

Powered by Google App Engine
This is Rietveld 408576698