Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2212333002: [test] Make test duplication more robust (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make test duplication more robust This makes test outcomes immutable. This has two benefits: 1) It's more robust. Using the |= operator by mistake wouldn't lead to unwanted mutation. 2) It's faster as now the set reference can be copied again when copying test cases. Test case copying happens an order of magnitude more often than rules do apply. BUG=v8:5238 Committed: https://crrev.com/04bda550c26e10624db016e8362849044d771483 Cr-Commit-Position: refs/heads/master@{#38373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testrunner/objects/testcase.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Michael Achenbach
PTAL. Measured with cProfile. This gives a small perf improvement on top of additional robustness.
4 years, 4 months ago (2016-08-05 10:12:18 UTC) #4
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-08-05 10:25:48 UTC) #7
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-05 11:00:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212333002/1
4 years, 4 months ago (2016-08-05 11:47:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 11:51:26 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 11:51:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04bda550c26e10624db016e8362849044d771483
Cr-Commit-Position: refs/heads/master@{#38373}

Powered by Google App Engine
This is Rietveld 408576698