Call FetchImageCallback asynchronously when no thumbnail exists

Call FetchImageCallback asynchronously when no thumbnail exists

When a thumbnail image for a ContentSuggestion is requested by the UI
and the thumbnail cannot be delivered for any reason, run the callback
with an empty image asynchronously to be consistent with normal
callback behaviors.

BUG=619560
Committed: https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb
Cr-Commit-Position: refs/heads/master@{#410055}

[Philipp Keck, 2016-08-05 08:28:15]

pke@google.com changed reviewers:
+ treib@chromium.org

[Philipp Keck, 2016-08-05 08:28:15]

PTAL

Previous discussion is here:
https://codereview.chromium.org/2214683002/diff/20001/components/ntp_snippets...

[Marc Treib, 2016-08-05 09:55:21]

LGTM, thanks!

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
File components/ntp_snippets/content_suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
components/ntp_snippets/content_suggestions_service_unittest.cc:269:
base::RunLoop run_loop_;
run_loop (no trailing underscore)

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
components/ntp_snippets/content_suggestions_service_unittest.cc:273:
.WillOnce(InvokeWithoutArgs(&run_loop_, &base::RunLoop::Quit));
Pretty neat pattern, haven't seen this before! Nice!

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
File components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
(left):

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc:61:
// TODO(pke): Implement.
The TODO can probably stay :)

[Philipp Keck, 2016-08-05 10:01:39]

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
File components/ntp_snippets/content_suggestions_service_unittest.cc (right):

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
components/ntp_snippets/content_suggestions_service_unittest.cc:269:
base::RunLoop run_loop_;
On 2016/08/05 09:55:20, Marc Treib wrote:
> run_loop (no trailing underscore)

Done.

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
File components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
(left):

https://codereview.chromium.org/2212313002/diff/40001/components/ntp_snippets...
components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc:61:
// TODO(pke): Implement.
On 2016/08/05 09:55:20, Marc Treib wrote:
> The TODO can probably stay :)

Done.

[Philipp Keck, 2016-08-05 13:32:45]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-05 13:32:45]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2212313002/#ps60001
(title: "Marc's comments")

[commit-bot: I haz the power, 2016-08-05 13:33:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 14:20:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 14:21:52]

Description was changed from

==========
Call FetchImageCallback asynchronously when no thumbnail exists

When a thumbnail image for a ContentSuggestion is requested by the UI
and the thumbnail cannot be delivered for any reason, run the callback
with an empty image asynchronously to be consistent with normal
callback behaviors.

BUG=619560
==========

to

==========
Call FetchImageCallback asynchronously when no thumbnail exists

When a thumbnail image for a ContentSuggestion is requested by the UI
and the thumbnail cannot be delivered for any reason, run the callback
with an empty image asynchronously to be consistent with normal
callback behaviors.

BUG=619560

Committed: https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb
Cr-Commit-Position: refs/heads/master@{#410055}
==========

[commit-bot: I haz the power, 2016-08-05 14:21:52]

Patchset 4 (id:??) landed as
https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb
Cr-Commit-Position: refs/heads/master@{#410055}