Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: chrome/browser/chromeos/note_taking_app_utils.cc

Issue 2212303003: Implement app launch changes for app runtime extension proposal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tool-screenshot
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/note_taking_app_utils.cc
diff --git a/chrome/browser/chromeos/note_taking_app_utils.cc b/chrome/browser/chromeos/note_taking_app_utils.cc
index 1e3cef1ae66c233cac487ed25b832f1efc7ecb18..cf59049cdd90a3b206f3dacac3ee75189086eb45 100644
--- a/chrome/browser/chromeos/note_taking_app_utils.cc
+++ b/chrome/browser/chromeos/note_taking_app_utils.cc
@@ -75,13 +75,9 @@ void LaunchNoteTakingAppForNewNote(Profile* profile,
return;
}
- // TODO(derat): Launch with a "create new note" launch action once that's been
- // added to chrome.appRuntime. Also decide what should be passed as the launch
- // source.
- if (path.empty())
- apps::LaunchPlatformApp(profile, app, extensions::SOURCE_UNTRACKED);
- else
- apps::LaunchPlatformAppWithPath(profile, app, path);
+ extensions::ActionData action_data;
+ action_data.action_type = extensions::ActionType::NEW_NOTE;
+ apps::LaunchPlatformAppWithAction(profile, app, action_data, path);
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698