Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2212273002: [serial] Cancel read watcher if immediate read succeeded. (Closed)

Created:
4 years, 4 months ago by aschulman
Modified:
4 years, 4 months ago
CC:
charliea (OOO until 10-5), chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel read watcher if an immediate read succeeds. Otherwise the pending_read_buffer can be overwritten by the read watcher when it triggers before a queued up ReadCompleted() call. BUG=634278 Committed: https://crrev.com/42b13d59919ca019e92b4decd0e7db5a636b1c32 Cr-Commit-Position: refs/heads/master@{#410148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M device/serial/serial_io_handler_posix.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
aschulman
4 years, 4 months ago (2016-08-05 05:03:29 UTC) #3
charliea (OOO until 10-5)
nit: the CL subject shouldn't repeated in the first paragraph of the CL description non-owner ...
4 years, 4 months ago (2016-08-05 16:07:10 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-05 18:20:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212273002/1
4 years, 4 months ago (2016-08-05 19:10:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:48:03 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42b13d59919ca019e92b4decd0e7db5a636b1c32 Cr-Commit-Position: refs/heads/master@{#410148}
4 years, 4 months ago (2016-08-05 19:49:39 UTC) #13
aschulman
4 years, 4 months ago (2016-08-06 04:10:29 UTC) #14
Message was sent while issue was closed.
On 2016/08/05 16:07:10, charliea wrote:
> nit: the CL subject shouldn't repeated in the first paragraph of the CL
> description
> 
> non-owner lgtm

whoops, I misinterpreted this comment and blew away the commit subject from the
description. I didn't realize that the first sentence of my description
contained the same information as the commit subject.

Powered by Google App Engine
This is Rietveld 408576698