Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2212253002: Converted Observatory class-tree element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Manage non-canonical classes #

Patch Set 3 : Removed autoExpandWholeTree flag at initialization #

Total comments: 2

Patch Set 4 : Added tests #

Patch Set 5 : Removed tmp code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -218 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 1 chunk +14 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 1 2 3 1 chunk +154 lines, -122 lines 0 comments Download
D runtime/observatory/lib/src/elements/class_tree.html View 1 chunk +0 lines, -42 lines 0 comments Download
M runtime/observatory/lib/src/elements/containers/virtual_collection.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/containers/virtual_tree.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 3 chunks +96 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/class.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/instance.dart View 1 2 3 1 chunk +75 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/repositories/class.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/instance.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/script.dart View 1 chunk +3 lines, -1 line 0 comments Download
D runtime/observatory/lib/src/models/repository.dart View 1 chunk +0 lines, -9 lines 0 comments Download
A runtime/observatory/lib/src/repositories/class.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/instance.dart View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/class_tree/element_test.dart View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/class_tree/element_test.html View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/class.dart View 1 2 3 1 chunk +12 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/class.dart View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/instance.dart View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/script.dart View 1 2 3 1 chunk +10 lines, -8 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/source_link/element_test.dart View 1 2 3 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-05 03:26:23 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-05 03:26:24 UTC) #3
Cutch
https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/elements/class_tree.dart File runtime/observatory/lib/src/elements/class_tree.dart (right): https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/elements/class_tree.dart#newcode193 runtime/observatory/lib/src/elements/class_tree.dart:193: /* remove deleted code https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/repositories/class.dart File runtime/observatory/lib/src/repositories/class.dart (right): https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/repositories/class.dart#newcode16 ...
4 years, 4 months ago (2016-08-05 13:23:19 UTC) #4
cbernaschina
https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/elements/class_tree.dart File runtime/observatory/lib/src/elements/class_tree.dart (right): https://codereview.chromium.org/2212253002/diff/1/runtime/observatory/lib/src/elements/class_tree.dart#newcode193 runtime/observatory/lib/src/elements/class_tree.dart:193: /* On 2016/08/05 13:23:18, Cutch wrote: > remove deleted ...
4 years, 4 months ago (2016-08-05 17:16:46 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-05 17:21:23 UTC) #6
Cutch
lgtm https://codereview.chromium.org/2212253002/diff/40001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/2212253002/diff/40001/runtime/observatory/lib/src/service/object.dart#newcode2493 runtime/observatory/lib/src/service/object.dart:2493: print(map); remove this before submitting
4 years, 4 months ago (2016-08-05 17:53:24 UTC) #7
Cutch
Also, remove the use of "as" and let checked mode fail if someone returns the ...
4 years, 4 months ago (2016-08-05 17:53:42 UTC) #8
cbernaschina
4 years, 4 months ago (2016-08-05 19:43:18 UTC) #10
cbernaschina
On 2016/08/05 17:53:42, Cutch wrote: > Also, remove the use of "as" and let checked ...
4 years, 4 months ago (2016-08-05 19:43:54 UTC) #11
cbernaschina
https://codereview.chromium.org/2212253002/diff/40001/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/2212253002/diff/40001/runtime/observatory/lib/src/service/object.dart#newcode2493 runtime/observatory/lib/src/service/object.dart:2493: print(map); On 2016/08/05 17:53:24, Cutch wrote: > remove this ...
4 years, 4 months ago (2016-08-05 19:47:48 UTC) #12
cbernaschina
4 years, 4 months ago (2016-08-05 19:48:16 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
3c786269cb1b0760da7547f54805a2b69f897641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698