Fix wrong PaintInvalidationIncremental on empty object

Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807
Committed: https://crrev.com/b9ec37cfc550102e95696f26173b95b729d00a60
Cr-Commit-Position: refs/heads/master@{#410231}

[Xianzhu, 2016-08-05 18:31:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-08-05 18:31:52]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-08-05 18:35:39]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 18:36:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-08-05 20:22:43]

Could you explain briefly how the bug exhibits and why this is the right fix?

[Xianzhu, 2016-08-05 20:27:24]

Description was changed from

==========
Fix wrong PaintInvalidationIncremental on empty object

BUG=634807
==========

to

==========
Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807
==========

[Xianzhu, 2016-08-05 20:30:36]

On 2016/08/05 20:22:43, chrishtr wrote:
> Could you explain briefly how the bug exhibits and why this is the right fix?

Modified description as:

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

[chrishtr, 2016-08-05 20:39:13]

lgtm

[Xianzhu, 2016-08-05 20:48:22]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-08-05 20:48:26]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-08-05 20:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 22:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:09:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-08-05 23:11:36]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-08-05 23:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2212223004/#ps60001
(title: "-")

[commit-bot: I haz the power, 2016-08-05 23:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:43:47]

Description was changed from

==========
Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807
==========

to

==========
Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807
==========

[commit-bot: I haz the power, 2016-08-06 00:43:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-06 00:45:44]

Description was changed from

==========
Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807
==========

to

==========
Fix wrong PaintInvalidationIncremental on empty object

The bug was because LayoutBox::getPaintInvalidatinReason()
returned PaintInvalidationIncremental after
LayoutObject::getPaintInvalidationReason() returned
PaintInvalidationNone for an empty object. In the case we
should not do any paint invalidation but executed
incrementallyInvalidatePaint() and triggered the assertion
failure.

BUG=634807

Committed: https://crrev.com/b9ec37cfc550102e95696f26173b95b729d00a60
Cr-Commit-Position: refs/heads/master@{#410231}
==========

[commit-bot: I haz the power, 2016-08-06 00:45:46]

Patchset 4 (id:??) landed as
https://crrev.com/b9ec37cfc550102e95696f26173b95b729d00a60
Cr-Commit-Position: refs/heads/master@{#410231}