Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix histogram description Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 61ee242baeec2dd8f52f3254cd0c4e4d637014dc..8e8a9a764df92c23a11b46f0ae71dfd83b7c3ad3 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -383,6 +383,21 @@ static void runAutofocusTask(ExecutionContext* context)
}
}
+// These are logged to UMA, so don't re-arrange them without creating a new histogram.
+enum DocumentVisibilityForDeferredLoading {
+ Created,
+ WouldLoadBecauseVisible,
+ // TODO(dgrogan): Add WouldLoadBecauseTopOrLeft, WouldLoadBecauseDisplayNone, etc
+
+ DocumentVisibilityForDeferredLoadingEnd
+};
+
+static void RecordStateToHistogram(DocumentVisibilityForDeferredLoading state)
+{
+ DEFINE_STATIC_LOCAL(EnumerationHistogram, unseenFrameHistogram, ("Navigation.DeferredDocumentLoading.StatesV1", DocumentVisibilityForDeferredLoadingEnd));
+ unseenFrameHistogram.count(state);
+}
+
Document::Document(const DocumentInit& initializer, DocumentClassFlags documentClasses)
: ContainerNode(0, CreateDocument)
, TreeScope(*this)
@@ -454,6 +469,7 @@ Document::Document(const DocumentInit& initializer, DocumentClassFlags documentC
, m_hasViewportUnits(false)
, m_parserSyncPolicy(AllowAsynchronousParsing)
, m_nodeCount(0)
+ , m_visibilityWasLogged(false)
{
if (m_frame) {
DCHECK(m_frame->page());
@@ -488,6 +504,10 @@ Document::Document(const DocumentInit& initializer, DocumentClassFlags documentC
setURL(initializer.url());
initSecurityContext(initializer);
+ DCHECK(getSecurityOrigin());
+ if (frame() && frame()->tree().top()->securityContext() && !getSecurityOrigin()->canAccess(frame()->tree().top()->securityContext()->getSecurityOrigin()))
+ RecordStateToHistogram(Created);
+
initDNSPrefetch();
InstanceCounters::incrementCounter(InstanceCounters::DocumentCounter);
@@ -6018,6 +6038,15 @@ DEFINE_TRACE(Document)
SecurityContext::trace(visitor);
}
+void Document::onVisibilityMaybeChanged(bool visible)
+{
+ DCHECK(frame());
+ if (visible && !m_visibilityWasLogged && frame()->isCrossOriginSubframe()) {
+ m_visibilityWasLogged = true;
+ RecordStateToHistogram(WouldLoadBecauseVisible);
+ }
+}
+
DEFINE_TRACE_WRAPPERS(Document)
{
visitor->traceWrappers(m_importsController);
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698