Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to Document Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 50137729160c42130d6a2ec3d239691f308eca76..8a24f5d6bfe004126297e979cafae373622e3b32 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -4260,6 +4260,9 @@ void FrameView::notifyRenderThrottlingObservers()
updateThrottlingStatus();
+ if (frame().document())
dcheng 2016/08/29 20:37:19 Do we need to do this check because Widget isn't s
dgrogan 2016/08/31 19:52:41 Not sure... I was cargo-culting from the first cla
dcheng 2016/09/01 21:24:26 Looking at the code, I'm actually not sure how we'
+ frame().document()->onVisibilityMaybeChanged(!m_hiddenForThrottling);
+
bool becameThrottled = !wasThrottled && canThrottleRendering();
bool becameUnthrottled = wasThrottled && !canThrottleRendering();
ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator();

Powered by Google App Engine
This is Rietveld 408576698