third_party/WebKit/Source/core/frame/LocalFrame.h - Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use frameloader->stateMachine. kill racy DCHECK. rename histogram Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.h

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h

index 67c3960b3bd4bdc7107d37476c7b5903f02c095b..3fd784ad7ab7bc0e3af97f0106f0ee8eb81c77e4 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.h

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h

@@ -193,6 +193,9 @@ public:

PluginData* pluginData() const;

+ void didInstallNewRealDocument();

+ void onVisibilityMaybeChanged(bool visible);

private:

friend class FrameNavigationDisabler;

@@ -236,6 +239,9 @@ private:

Member<InstrumentingAgents> m_instrumentingAgents;

InterfaceProvider* const m_interfaceProvider;

+ bool m_visibilityWasLogged;

+ bool m_creationWasLogged;

};

inline void LocalFrame::init()