Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: log creation after installNewDocument Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 void scheduleVisualUpdateUnlessThrottled(); 186 void scheduleVisualUpdateUnlessThrottled();
187 187
188 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; } 188 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; }
189 189
190 InterfaceProvider* interfaceProvider() { return m_interfaceProvider; } 190 InterfaceProvider* interfaceProvider() { return m_interfaceProvider; }
191 191
192 FrameLoaderClient* client() const; 192 FrameLoaderClient* client() const;
193 193
194 PluginData* pluginData() const; 194 PluginData* pluginData() const;
195 195
196 void didInstallNewDocument();
197 void onVisibilityMaybeChanged(bool visible);
198
196 private: 199 private:
197 friend class FrameNavigationDisabler; 200 friend class FrameNavigationDisabler;
198 201
199 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, InterfaceProvider*); 202 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, InterfaceProvider*);
200 203
201 // Internal Frame helper overrides: 204 // Internal Frame helper overrides:
202 WindowProxyManager* getWindowProxyManager() const override; 205 WindowProxyManager* getWindowProxyManager() const override;
203 // Intentionally private to prevent redundant checks when the type is 206 // Intentionally private to prevent redundant checks when the type is
204 // already LocalFrame. 207 // already LocalFrame.
205 bool isLocalFrame() const override { return true; } 208 bool isLocalFrame() const override { return true; }
(...skipping 23 matching lines...) Expand all
229 int m_navigationDisableCount; 232 int m_navigationDisableCount;
230 233
231 float m_pageZoomFactor; 234 float m_pageZoomFactor;
232 float m_textZoomFactor; 235 float m_textZoomFactor;
233 236
234 bool m_inViewSourceMode; 237 bool m_inViewSourceMode;
235 238
236 Member<InstrumentingAgents> m_instrumentingAgents; 239 Member<InstrumentingAgents> m_instrumentingAgents;
237 240
238 InterfaceProvider* const m_interfaceProvider; 241 InterfaceProvider* const m_interfaceProvider;
242
243 bool m_visibilityWasLogged;
244 bool m_creationWasLogged;
239 }; 245 };
240 246
241 inline void LocalFrame::init() 247 inline void LocalFrame::init()
242 { 248 {
243 m_loader.init(); 249 m_loader.init();
244 } 250 }
245 251
246 inline LocalDOMWindow* LocalFrame::localDOMWindow() const 252 inline LocalDOMWindow* LocalFrame::localDOMWindow() const
247 { 253 {
248 return m_domWindow.get(); 254 return m_domWindow.get();
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 explicit ScopedFrameBlamer(LocalFrame*); 351 explicit ScopedFrameBlamer(LocalFrame*);
346 ~ScopedFrameBlamer(); 352 ~ScopedFrameBlamer();
347 353
348 private: 354 private:
349 Member<LocalFrame> m_frame; 355 Member<LocalFrame> m_frame;
350 }; 356 };
351 357
352 } // namespace blink 358 } // namespace blink
353 359
354 #endif // LocalFrame_h 360 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698