Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2212183004: Log to UMA when x-origin frames (1) are created and (2) become visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 void scheduleVisualUpdateUnlessThrottled(); 178 void scheduleVisualUpdateUnlessThrottled();
179 179
180 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; } 180 bool isNavigationAllowed() const { return m_navigationDisableCount == 0; }
181 181
182 ServiceRegistry* serviceRegistry() { return m_serviceRegistry; } 182 ServiceRegistry* serviceRegistry() { return m_serviceRegistry; }
183 183
184 FrameLoaderClient* client() const; 184 FrameLoaderClient* client() const;
185 185
186 PluginData* pluginData() const; 186 PluginData* pluginData() const;
187 187
188 void onVisibilityMaybeChanged(bool visible);
189
188 private: 190 private:
189 friend class FrameNavigationDisabler; 191 friend class FrameNavigationDisabler;
190 192
191 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, ServiceRegistry*); 193 LocalFrame(FrameLoaderClient*, FrameHost*, FrameOwner*, ServiceRegistry*);
192 194
193 // Internal Frame helper overrides: 195 // Internal Frame helper overrides:
194 WindowProxyManager* getWindowProxyManager() const override; 196 WindowProxyManager* getWindowProxyManager() const override;
195 // Intentionally private to prevent redundant checks when the type is 197 // Intentionally private to prevent redundant checks when the type is
196 // already LocalFrame. 198 // already LocalFrame.
197 bool isLocalFrame() const override { return true; } 199 bool isLocalFrame() const override { return true; }
(...skipping 22 matching lines...) Expand all
220 int m_navigationDisableCount; 222 int m_navigationDisableCount;
221 223
222 float m_pageZoomFactor; 224 float m_pageZoomFactor;
223 float m_textZoomFactor; 225 float m_textZoomFactor;
224 226
225 bool m_inViewSourceMode; 227 bool m_inViewSourceMode;
226 228
227 Member<InstrumentingAgents> m_instrumentingAgents; 229 Member<InstrumentingAgents> m_instrumentingAgents;
228 230
229 ServiceRegistry* const m_serviceRegistry; 231 ServiceRegistry* const m_serviceRegistry;
232
233 bool m_visibilityWasLogged;
234 bool m_creationWasLogged;
230 }; 235 };
231 236
232 inline void LocalFrame::init() 237 inline void LocalFrame::init()
233 { 238 {
234 m_loader.init(); 239 m_loader.init();
235 } 240 }
236 241
237 inline LocalDOMWindow* LocalFrame::localDOMWindow() const 242 inline LocalDOMWindow* LocalFrame::localDOMWindow() const
238 { 243 {
239 return m_domWindow.get(); 244 return m_domWindow.get();
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 explicit ScopedFrameBlamer(LocalFrame*); 341 explicit ScopedFrameBlamer(LocalFrame*);
337 ~ScopedFrameBlamer(); 342 ~ScopedFrameBlamer();
338 343
339 private: 344 private:
340 Member<LocalFrame> m_frame; 345 Member<LocalFrame> m_frame;
341 }; 346 };
342 347
343 } // namespace blink 348 } // namespace blink
344 349
345 #endif // LocalFrame_h 350 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698