third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build + feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/resource_provider.cc ('K') | « third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp ('k') | third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index f10007a9157adcbfd4525b9c31d43fdaf037d500..3dd126c281818f01f668c9ac2f126feabd76dc9d 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -299,7 +299,7 @@ void CompositedLayerMapping::updateContentsOpaque()

if (isAcceleratedCanvas(layoutObject())) {

// Determine whether the rendering context's external texture layer is opaque.

CanvasRenderingContext* context = toHTMLCanvasElement(layoutObject()->node())->renderingContext();

- if (!context->hasAlpha())

+ if (!context->creationAttributes().alpha())

m_graphicsLayer->setContentsOpaque(true);

else if (WebLayer* layer = context->platformLayer())

m_graphicsLayer->setContentsOpaque(!Color(layer->backgroundColor()).hasAlpha());