third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build and tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl ('K') | « third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h ('k') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('j') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

index cc07c234512e3d62e1577257d552e834c25506ce..8339235e3de007d2c1d649a03a1d214230a51bb1 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp

@@ -40,8 +40,8 @@

namespace blink {

-AcceleratedImageBufferSurface::AcceleratedImageBufferSurface(const IntSize& size, OpacityMode opacityMode)

- : ImageBufferSurface(size, opacityMode)

+AcceleratedImageBufferSurface::AcceleratedImageBufferSurface(const IntSize& size, OpacityMode opacityMode, sk_sp<SkColorSpace> colorSpace)

+ : ImageBufferSurface(size, opacityMode, colorSpace)

{

m_contextProvider = wrapUnique(Platform::current()->createSharedOffscreenGraphicsContext3DProvider());

if (!m_contextProvider)