third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build and tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl ('K') | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h ('k') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('j') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

index 11b5738a0de4fd70cbd05bcc3793dcbe17b57fd9..ce00f07a0d4c38b424b2cb6a86ad9eec6b184080 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

@@ -17,8 +17,8 @@

namespace blink {

-RecordingImageBufferSurface::RecordingImageBufferSurface(const IntSize& size, std::unique_ptr<RecordingImageBufferFallbackSurfaceFactory> fallbackFactory, OpacityMode opacityMode)

- : ImageBufferSurface(size, opacityMode)

+RecordingImageBufferSurface::RecordingImageBufferSurface(const IntSize& size, std::unique_ptr<RecordingImageBufferFallbackSurfaceFactory> fallbackFactory, OpacityMode opacityMode, sk_sp<SkColorSpace> colorSpace)

+ : ImageBufferSurface(size, opacityMode, std::move(colorSpace))

, m_imageBuffer(0)

, m_currentFramePixelCount(0)

, m_previousFramePixelCount(0)

@@ -82,7 +82,7 @@ void RecordingImageBufferSurface::fallBackToRasterCanvas(FallbackReason reason)

DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, canvasFallbackHistogram, new EnumerationHistogram("Canvas.DisplayListFallbackReason", FallbackReasonCount));

canvasFallbackHistogram.count(reason);

- m_fallbackSurface = m_fallbackFactory->createSurface(size(), getOpacityMode());

+ m_fallbackSurface = m_fallbackFactory->createSurface(size(), getOpacityMode(), colorSpace());

m_fallbackSurface->setImageBuffer(m_imageBuffer);

if (m_previousFrame) {