third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build and tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl ('K') | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

index 99ee04a0d65423587aee828781675fd640d1e168..a5965778b137958c2b3caa7f0eb0fd12824fb5db 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

@@ -218,7 +218,7 @@ public:

DECLARE_VIRTUAL_TRACE();

protected:

- WebGL2RenderingContextBase(HTMLCanvasElement*, std::unique_ptr<WebGraphicsContext3DProvider>, const WebGLContextAttributes& requestedAttributes);

+ WebGL2RenderingContextBase(HTMLCanvasElement*, std::unique_ptr<WebGraphicsContext3DProvider>, const CanvasContextCreationAttributes& requestedAttributes);

// Helper function to validate target and the attachment combination for getFramebufferAttachmentParameters.

// Generate GL error and return false if parameters are illegal.