third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build and tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl ('K') | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp » ('j') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

index 33702391887d2e8bbc32ac8e7daedd065c0df68a..edb1ad3296c59f821c80febd4efc9ca649b88098 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

@@ -69,7 +69,7 @@ public:

void validateStateStack() final;

- bool hasAlpha() const override { return m_hasAlpha; }

+ bool hasAlpha() const final { return CanvasRenderingContext::hasAlpha(); }

bool isContextLost() const override;

ImageBitmap* transferToImageBitmap(ExceptionState&) final;

@@ -79,7 +79,6 @@ protected:

DECLARE_VIRTUAL_TRACE();

private:

- bool m_hasAlpha;

bool m_needsMatrixClipRestore = false;

std::unique_ptr<ImageBuffer> m_imageBuffer;

};