third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build and tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/Canvas2DContextAttributes.idl ('K') | « third_party/WebKit/Source/modules/canvas2d/ContextAttributeHelpers.cpp ('k') | third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp » ('j') | third_party/WebKit/public/platform/WebExternalTextureMailbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h

diff --git a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h

index e6b2cccbdc2fd214400cce05bb9b2f066820334b..24312b46d32053ed8fbc5164a06aec921f788322 100644

--- a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h

+++ b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h

@@ -32,7 +32,6 @@ public:

// CanvasRenderingContext implementation

ContextType getContextType() const override { return CanvasRenderingContext::ContextImageBitmap; }

- bool hasAlpha() const override { return m_hasAlpha; }

void setIsHidden(bool) override { }

bool isContextLost() const override { return false; }

bool paint(GraphicsContext&, const IntRect&) override;

@@ -48,9 +47,8 @@ public:

virtual ~ImageBitmapRenderingContext();

private:

- ImageBitmapRenderingContext(HTMLCanvasElement*, CanvasContextCreationAttributes, Document&);

+ ImageBitmapRenderingContext(HTMLCanvasElement*, const CanvasContextCreationAttributes&, Document&);

- bool m_hasAlpha;

RefPtr<Image> m_image;

};