third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp - Issue 2212163002: Add some plumbing for the color management of canvases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2212163002: Add some plumbing for the color management of canvases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

index 65f3f5bb41907120e921840bbce2dae8adacd2a1..202212cc1ffdb1fc6624314e2f76e6b1c5b9c310 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

@@ -24,8 +24,7 @@ OffscreenCanvasRenderingContext2D::~OffscreenCanvasRenderingContext2D()

}

OffscreenCanvasRenderingContext2D::OffscreenCanvasRenderingContext2D(ScriptState* scriptState, OffscreenCanvas* canvas, const CanvasContextCreationAttributes& attrs)

- : CanvasRenderingContext(nullptr, canvas)

- , m_hasAlpha(attrs.alpha())

+ : CanvasRenderingContext(nullptr, canvas, attrs)

{

ExecutionContext* executionContext = scriptState->getExecutionContext();

if (executionContext->isDocument()) {

@@ -93,7 +92,7 @@ ImageBuffer* OffscreenCanvasRenderingContext2D::imageBuffer() const

{

if (!m_imageBuffer) {

IntSize surfaceSize(width(), height());

- OpacityMode opacityMode = m_hasAlpha ? NonOpaque : Opaque;

+ OpacityMode opacityMode = hasAlpha() ? NonOpaque : Opaque;

std::unique_ptr<ImageBufferSurface> surface;

if (shouldAccelerate(surfaceSize)) {

surface.reset(new AcceleratedImageBufferSurface(surfaceSize, opacityMode));