Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2212133003: Fix compilation failure when v8 compiled with GCC 5.x due to `-Werror=unused-variable` (Closed)

Created:
4 years, 4 months ago by ivica.bogosavljevic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compilation failure when v8 compiled with GCC 5.x due to `-Werror=unused-variable` BUG= Committed: https://crrev.com/20c56bdd6e494c1e15bbf800dd6946033ba77187 Cr-Commit-Position: refs/heads/master@{#38385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/unittests/compiler/linkage-tail-call-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ivica.bogosavljevic
PTAL
4 years, 4 months ago (2016-08-05 12:09:11 UTC) #3
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-05 12:11:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212133003/1
4 years, 4 months ago (2016-08-05 12:11:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:55:34 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:56:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20c56bdd6e494c1e15bbf800dd6946033ba77187
Cr-Commit-Position: refs/heads/master@{#38385}

Powered by Google App Engine
This is Rietveld 408576698