Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: appengine/swarming/handlers_backend.py

Issue 2212073002: Add endpoint and cron job to aggregate all dimensions and values (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/handlers_backend.py
diff --git a/appengine/swarming/handlers_backend.py b/appengine/swarming/handlers_backend.py
index bbcdc6bc90678b32459613a04a3983d496827665..ee398790eeacbe1e2a39a0ee8a833567ce537c23 100644
--- a/appengine/swarming/handlers_backend.py
+++ b/appengine/swarming/handlers_backend.py
@@ -12,9 +12,12 @@ from google.appengine.api import app_identity
from google.appengine.api import datastore_errors
from google.appengine.api import taskqueue
+from components import utils
+
import mapreduce_jobs
from components import decorators
from components import machine_provider
+from server import bot_management
from server import config
from server import lease_management
from server import stats
@@ -97,6 +100,30 @@ class CronMachineProviderCleanUpHandler(webapp2.RequestHandler):
lease_management.clean_up_bots()
+class CronBotsDimensionAggregationHandler(webapp2.RequestHandler):
+ """Aggregates all bots dimensions (except id) in the fleet."""
+
+ @decorators.require_cronjob
+ def get(self):
+ seen = {}
+ now = utils.utcnow()
+ for b in bot_management.BotInfo.query():
+ for i in b.dimensions_flat:
+ k, v = i.split(':', 1)
+ if k != 'id':
+ seen.setdefault(k, set()).add(v)
+ dims = [
+ bot_management.DimensionValues(dimension=k,values=sorted(values))
+ for k, values in sorted(seen.iteritems())
+ ]
+
+ logging.info('Saw dimensions %s', dims)
+ bot_management.DimensionAggregation(
+ key=bot_management.DimensionAggregation.KEY,
+ dimensions=dims,
+ ts=now).put()
+
+
class CronMachineProviderPubSubHandler(webapp2.RequestHandler):
"""Listens for Pub/Sub communication from Machine Provider."""
@@ -170,6 +197,8 @@ def get_routes():
('/internal/cron/stats/update', stats.InternalStatsUpdateHandler),
('/internal/cron/trigger_cleanup_data', CronTriggerCleanupDataHandler),
+ ('/internal/cron/aggregate_bots_dimensions',
+ CronBotsDimensionAggregationHandler),
('/internal/cron/machine_provider', CronMachineProviderBotHandler),
('/internal/cron/machine_provider_cleanup',
CronMachineProviderCleanUpHandler),

Powered by Google App Engine
This is Rietveld 408576698