Add endpoint and cron job to aggregate all dimensions and values

appengine/swarming/handlers_endpoints.py

 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """This module defines Swarming Server endpoints handlers."""
 
 import datetime
 import logging
 
 from google.appengine.api import datastore_errors
@@ skipping 626 matching lines @@
 
   @gae_ts_mon.instrument_endpoint()
   @auth.endpoints_method(
       swarming_rpcs.BotsRequest, swarming_rpcs.BotsCount,
       http_method='GET')
   @auth.require(acl.is_privileged_user)
   def count(self, request):
     """Counts number of bots with given dimensions."""
     logging.info('%s', request)
     now = utils.utcnow()
-    q = bot_management.BotInfo.query().order()
+    q = bot_management.BotInfo.query()
     for d in request.dimensions:
       parts = d.split(':', 1)
       if len(parts) != 2 or any(i.strip() != i or not i for i in parts):
         raise endpoints.BadRequestException('Invalid dimensions: %s' % d)
       q = q.filter(bot_management.BotInfo.dimensions_flat == d)
     f_count = q.count_async()
     dt = datetime.timedelta(seconds=config.settings().bot_death_timeout_secs)
     timeout = now - dt
     f_dead = q.filter(
         bot_management.BotInfo.last_seen_ts < timeout).count_async()
     f_quarantined = q.filter(
         bot_management.BotInfo.quarantined == True).count_async()
     f_busy = q.filter(bot_management.BotInfo.is_busy == True).count_async()
     return swarming_rpcs.BotsCount(
         count=f_count.get_result(),
         quarantined=f_quarantined.get_result(),
         dead=f_dead.get_result(),
         busy=f_busy.get_result(),
         now=now)
 
+  @gae_ts_mon.instrument_endpoint()
+  @auth.endpoints_method(
+      message_types.VoidMessage, swarming_rpcs.BotsDimensions,
+      http_method='GET')
+  @auth.require(acl.is_privileged_user)
+  def dimensions(self, request):
+    """Returns the cached set of dimensions currently in use in the fleet."""
+    logging.info('%s', request)
+    dims = bot_management.DimensionAggregation.KEY.get()
+    fd = [swarming_rpcs.StringListPair(

[M-A Ruel, 2016/08/05 18:06:01]

same about alignment.

you could probably inline it (?)

[kjlubick, 2016/08/05 18:28:42]

Done.  No inline.

+        key=d.dimension,
+        value=d.values) for d in dims.dimensions]
+    return swarming_rpcs.BotsDimensions(
+      bots_dimensions=fd)

[M-A Ruel, 2016/08/05 18:06:01]

add ts=dims.ts

[kjlubick, 2016/08/05 18:28:42]

ts added to swarming_rpcs.BotsDimensions as well.

+
 
 def get_routes():
   return (
     endpoints_webapp2.api_routes(SwarmingServerService) +
     endpoints_webapp2.api_routes(SwarmingTaskService) +
     endpoints_webapp2.api_routes(SwarmingTasksService) +
     endpoints_webapp2.api_routes(SwarmingBotService) +
     endpoints_webapp2.api_routes(SwarmingBotsService) +
     # components.config endpoints for validation and configuring of luci-config
     # service URL.
     endpoints_webapp2.api_routes(config.ConfigApi))