[Autofill] Implement Autofill Assistant infobar for iOS

components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc

Index: components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
diff --git a/components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc b/components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
index 432bb262becf4bb2ec5a594c2d22a3a73b09b7e5..3d06fe18a977b014f71e69fe98718809ce84136d 100644
--- a/components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
+++ b/components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
@@ -22,9 +22,17 @@ AutofillCreditCardFillingInfoBarDelegateMobile::
       card_filling_callback_(card_filling_callback),
       had_user_interaction_(false),
       was_shown_(false),
+#if defined(OS_IOS)
+      // TODO(jdonnelly): Use credit card issuer images on iOS.

[Justin Donnelly, 2016/08/05 14:45:19]

The existing TODO this is copied from is there because the new save card infobar
isn't launched on iOS yet. In other words, I haven't added the images yet
because we simply don't need them.

If you're introducing a UI now that needs them, you should go ahead and add them
in this CL. Unless the designer specifically *doesn't* want the card type icon
in this UI, in which case this TODO is not necessary.

[Mathieu, 2016/08/05 16:57:04]

I removed the ifdef because it turns out the resources are in iOS anyway[1]
(perhaps for some other feature?) and it will be ready for when the infobar can
include them. However I didn't use the issuer_icon_id_ as the icon for the whole
infobar because it looks weird [2].

[1]
https://cs.chromium.org/chromium/src/components/resources/autofill_scaled_res...
[2] https://drive.google.com/open?id=0B3xzZ-vFr2LRMzhuRDlpQ1NBUUk

+      // http://crbug.com/535784
+      issuer_icon_id_(kNoIconID),
+      card_type_(CreditCard::TypeForDisplay(card.type())),
+#else
       issuer_icon_id_(CreditCard::IconResourceId(card.type())),
+#endif
       card_label_(base::string16(kMidlineEllipsis) + card.LastFourDigits()),

[Justin Donnelly, 2016/08/05 14:45:19]

If we're not going to use icons on iOS, instead of introducing a separate field
(card_type_), make card_label_ on iOS contain card.TypeAndLastFourDigits() and
use that in IDS_AUTOFILL_CREDIT_CARD_FILLING_INFOBAR_FORMATTED_TITLE.
TypeAndLastFourDigits returns a string which uses kNonBreakingSpace to ensure
that "Visa" doesn't get separated from "-1234".

[Mathieu, 2016/08/05 16:57:04]

Thanks, I should have caught that.

-      card_sub_label_(card.AbbreviatedExpirationDateForDisplay()) {}
+      card_sub_label_(card.AbbreviatedExpirationDateForDisplay()) {

[Justin Donnelly, 2016/08/05 14:45:19]

Don't we need the expiration date in the iOS UI?

[Mathieu, 2016/08/05 16:57:04]

It would be nice, and hopefully we get to have the infobar with card detail
before we launch "save card" and this.

[Justin Donnelly, 2016/08/05 18:20:20]

I'd say it's must-have not just nice but this is fine for now.

+}
 
 AutofillCreditCardFillingInfoBarDelegateMobile::
     ~AutofillCreditCardFillingInfoBarDelegateMobile() {
@@ -42,8 +50,15 @@ int AutofillCreditCardFillingInfoBarDelegateMobile::GetIconId() const {
 
 base::string16 AutofillCreditCardFillingInfoBarDelegateMobile::GetMessageText()
     const {
+#if defined(OS_ANDROID)
   return l10n_util::GetStringUTF16(
       IDS_AUTOFILL_CREDIT_CARD_FILLING_INFOBAR_TITLE);
+#elif defined(OS_IOS)
+  // On iOS the card details are in the title of the infobar.
+  return l10n_util::GetStringFUTF16(
+      IDS_AUTOFILL_CREDIT_CARD_FILLING_INFOBAR_FORMATTED_TITLE, card_type_,
+      card_label_);
+#endif
 }
 
 void AutofillCreditCardFillingInfoBarDelegateMobile::InfoBarDismissed() {