[Autofill] Implement Autofill Assistant infobar for iOS

[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the credit card details so these have been put in the title of the infobar.

Screenshot: https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656
Committed: https://crrev.com/10834e66e7e67bf2e00b1c913bd4acd0330f0433
Cr-Commit-Position: refs/heads/master@{#410170}

[Mathieu, 2016-08-04 20:37:51]

Description was changed from

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details.

BUG=630656
==========

to

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details so these have been put in the title of the infobar.

Screenshot:
https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656
==========

[Mathieu, 2016-08-04 20:37:51]

mathp@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Mathieu, 2016-08-04 20:42:08]

Patchset #2 (id:20001) has been deleted

[Mathieu, 2016-08-04 20:42:24]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2016-08-04 20:44:41]

Hi Justin, PTAL

[commit-bot: I haz the power, 2016-08-04 21:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 21:54:27]

Dry run: This issue passed the CQ dry run.

[Justin Donnelly, 2016-08-05 14:45:19]

Nice! Thanks for adding the iOS implementation. Just a few questions about how
we want the UI to look. Are there mocks?

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_assistant.cc (right):

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_assistant.cc:30: #if
!defined(OS_ANDROID) && !defined(OS_IOS)
Can this be moved inside IsAutofillCreditCardAssistEnabled()? Seems like "on the
right platform" is a natural part of "is enabled".

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
File
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
(right):

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:26:
// TODO(jdonnelly): Use credit card issuer images on iOS.
The existing TODO this is copied from is there because the new save card infobar
isn't launched on iOS yet. In other words, I haven't added the images yet
because we simply don't need them.

If you're introducing a UI now that needs them, you should go ahead and add them
in this CL. Unless the designer specifically *doesn't* want the card type icon
in this UI, in which case this TODO is not necessary.

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:33:
card_label_(base::string16(kMidlineEllipsis) + card.LastFourDigits()),
If we're not going to use icons on iOS, instead of introducing a separate field
(card_type_), make card_label_ on iOS contain card.TypeAndLastFourDigits() and
use that in IDS_AUTOFILL_CREDIT_CARD_FILLING_INFOBAR_FORMATTED_TITLE.
TypeAndLastFourDigits returns a string which uses kNonBreakingSpace to ensure
that "Visa" doesn't get separated from "-1234".

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:34:
card_sub_label_(card.AbbreviatedExpirationDateForDisplay()) {
Don't we need the expiration date in the iOS UI?

[Mathieu, 2016-08-05 16:57:04]

Thanks for your comments

Here are the Android mocks (internal)
https://folio.googleplex.com/chrome-ux/mocks/304-payments-zero-integration/ZI...

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_assistant.cc (right):

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_assistant.cc:30: #if
!defined(OS_ANDROID) && !defined(OS_IOS)
On 2016/08/05 14:45:19, Justin Donnelly wrote:
> Can this be moved inside IsAutofillCreditCardAssistEnabled()? Seems like "on
the
> right platform" is a natural part of "is enabled".

Sure, done

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
File
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
(right):

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:26:
// TODO(jdonnelly): Use credit card issuer images on iOS.
On 2016/08/05 14:45:19, Justin Donnelly wrote:
> The existing TODO this is copied from is there because the new save card
infobar
> isn't launched on iOS yet. In other words, I haven't added the images yet
> because we simply don't need them.
> 
> If you're introducing a UI now that needs them, you should go ahead and add
them
> in this CL. Unless the designer specifically *doesn't* want the card type icon
> in this UI, in which case this TODO is not necessary.

I removed the ifdef because it turns out the resources are in iOS anyway[1]
(perhaps for some other feature?) and it will be ready for when the infobar can
include them. However I didn't use the issuer_icon_id_ as the icon for the whole
infobar because it looks weird [2].

[1]
https://cs.chromium.org/chromium/src/components/resources/autofill_scaled_res...
[2] https://drive.google.com/open?id=0B3xzZ-vFr2LRMzhuRDlpQ1NBUUk

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:33:
card_label_(base::string16(kMidlineEllipsis) + card.LastFourDigits()),
On 2016/08/05 14:45:19, Justin Donnelly wrote:
> If we're not going to use icons on iOS, instead of introducing a separate
field
> (card_type_), make card_label_ on iOS contain card.TypeAndLastFourDigits() and
> use that in IDS_AUTOFILL_CREDIT_CARD_FILLING_INFOBAR_FORMATTED_TITLE.
> TypeAndLastFourDigits returns a string which uses kNonBreakingSpace to ensure
> that "Visa" doesn't get separated from "-1234".

Thanks, I should have caught that.

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:34:
card_sub_label_(card.AbbreviatedExpirationDateForDisplay()) {
On 2016/08/05 14:45:19, Justin Donnelly wrote:
> Don't we need the expiration date in the iOS UI?

It would be nice, and hopefully we get to have the infobar with card detail
before we launch "save card" and this.

[Justin Donnelly, 2016-08-05 18:20:20]

lgtm

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
File
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
(right):

https://codereview.chromium.org/2212063002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc:34:
card_sub_label_(card.AbbreviatedExpirationDateForDisplay()) {
On 2016/08/05 16:57:04, Mathieu Perreault wrote:
> On 2016/08/05 14:45:19, Justin Donnelly wrote:
> > Don't we need the expiration date in the iOS UI?
> 
> It would be nice, and hopefully we get to have the infobar with card detail
> before we launch "save card" and this.

I'd say it's must-have not just nice but this is fine for now.

https://codereview.chromium.org/2212063002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (left):

https://codereview.chromium.org/2212063002/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:70: // TODO(jdonnelly): Use
credit card issuer images on iOS.
Sweet! Now I'm down to 893 TODOs. ;-)

[Mathieu, 2016-08-05 18:38:05]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:38:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:18:29]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Mathieu, 2016-08-05 19:37:46]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-08-05 19:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/2212063002/#ps80001
(title: "fix ifdef")

[commit-bot: I haz the power, 2016-08-05 19:38:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 21:44:48]

Description was changed from

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details so these have been put in the title of the infobar.

Screenshot:
https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656
==========

to

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details so these have been put in the title of the infobar.

Screenshot:
https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656
==========

[commit-bot: I haz the power, 2016-08-05 21:44:49]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-05 21:48:13]

Description was changed from

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details so these have been put in the title of the infobar.

Screenshot:
https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656
==========

to

==========
[Autofill] Implement Autofill Assistant infobar for iOS

Reuses the infobar for the "save card" feature on iOS, which doesn't contain the
credit card details so these have been put in the title of the infobar.

Screenshot:
https://drive.google.com/file/d/0B3xzZ-vFr2LRRDYzVUdiNTBKSWM/view?usp=sharing

BUG=630656

Committed: https://crrev.com/10834e66e7e67bf2e00b1c913bd4acd0330f0433
Cr-Commit-Position: refs/heads/master@{#410170}
==========

[commit-bot: I haz the power, 2016-08-05 21:48:15]

Patchset 4 (id:??) landed as
https://crrev.com/10834e66e7e67bf2e00b1c913bd4acd0330f0433
Cr-Commit-Position: refs/heads/master@{#410170}