Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2212033002: Handle repeated headers when more than one table in paged context (Closed)

Created:
4 years, 4 months ago by rhogan
Modified:
4 years, 4 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, mstensho (USE GERRIT), slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@467579-4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle repeated headers when more than one table in paged context BUG=631222 Committed: https://crrev.com/f4f9dd5f2a9339d1b66a226580102d0bee4e4d38 Cr-Commit-Position: refs/heads/master@{#410657}

Patch Set 1 #

Patch Set 2 : bug 631222 #

Patch Set 3 : bug 631222 #

Messages

Total messages: 24 (13 generated)
rhogan
4 years, 4 months ago (2016-08-05 20:30:13 UTC) #6
Xianzhu
Based on the current behavior, it seems that we paint an extra header at the ...
4 years, 4 months ago (2016-08-05 21:49:26 UTC) #7
rhogan
On 2016/08/05 at 21:49:26, wangxianzhu wrote: > Based on the current behavior, it seems that ...
4 years, 4 months ago (2016-08-08 18:15:08 UTC) #8
Xianzhu
lgtm
4 years, 4 months ago (2016-08-08 18:26:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212033002/1
4 years, 4 months ago (2016-08-08 18:27:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/269136)
4 years, 4 months ago (2016-08-08 19:50:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212033002/20001
4 years, 4 months ago (2016-08-08 20:27:15 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/269227)
4 years, 4 months ago (2016-08-08 22:07:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212033002/40001
4 years, 4 months ago (2016-08-09 10:53:21 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 14:13:39 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 14:15:02 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4f9dd5f2a9339d1b66a226580102d0bee4e4d38
Cr-Commit-Position: refs/heads/master@{#410657}

Powered by Google App Engine
This is Rietveld 408576698