third_party/WebKit/LayoutTests/webaudio/unit-test-audio-testing.html - Issue 2212023002: Modifying audio-testing.js to support testharness.js.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/unit-test-audio-testing.html

Issue 2212023002: Modifying audio-testing.js to support testharness.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initial patch Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>A simple unit testing for audio-testing.js and testharness.js</title>

	5

	6 <!-- This is the required dependency for testharness + audio-testing. Note

	7 that the including order matters because audio-testing.js depends on

	8 testharness.js -->
	Raymond Toy 2016/08/04 18:07:08 Is this because audio-testing.js checks for testha Is this because audio-testing.js checks for testharness right away? Wouldn't it be better to check for testharness when we create the Audit object in Audit.createTaskRunner()? hongchan 2016/08/04 18:31:37 Should and Audit both rely on testharness. I think Show quoted text On 2016/08/04 18:07:08, Raymond Toy wrote: > Is this because audio-testing.js checks for testharness right away? Wouldn't it > be better to check for testharness when we create the Audit object in > Audit.createTaskRunner()? Should and Audit both rely on testharness. I think this is okay pattern - otherwise we have to check for testharness in every instance of Should().
	9 <script src="../resources/testharness.js"></script>

	10 <script src="../resources/testharnessreport.js"></script>

	11 <script src="resources/audio-testing.js"></script>

	12

	13 </head>

	14 <body>

	15 <script>

	16 var audit = Audit.createTaskRunner();

	17

	18 audit.defineTask('foo', function (taskDone) {

	19 Should('Zero', 0).beEqualTo(0);

	20 Should('One', 1).notBeEqualTo(0);

	21 Should('Expected SNR', 110).beGreaterThanOrEqualTo(100);

	22 taskDone();

	23 });

	24

	25 audit.defineTask('bar', function (taskDone) {

	26 var maxError = 1e-6;

	27 Should("Maximum error value", maxError).beLessThanOrEqualTo(1e-5);

	28 // Should("max error", maxError).beLessThanOrEqualTo(-1);

	29 Should('One point double zero one', 1.001).beCloseTo(1, .1);

	30 // Should('Two', 2).beCloseTo(1, .1);

	31 taskDone();

	32 });

	33

	34 audit.defineTask('boo', function (taskDone) {

	35 Should('[2, 2, 2]', [2, 2, 2]).beConstantValueOf(2);

	36 Should('[1, 2, 3]', [1, 2, 3]).beEqualToArray([1, 2, 3]);

	37 Should('My array', [0.11, 0.19]).beCloseToArray([0.1, 0.2], 0.02);

	38 Should('My random array', [1, 1, 3, 3, 2]).containValues([1, 3, 2]);

	39 taskDone();

	40 });

	41

	42 audit.runTasks();
	Raymond Toy 2016/08/04 18:07:08 This is a breaking change. We used to have to hav This is a breaking change. We used to have to have a final task that called finishJSTest(). It's not clear to me that audit should always automatically do this. hongchan 2016/08/04 18:31:37 Not sure why this is a breaking change. It does no Show quoted text On 2016/08/04 18:07:08, Raymond Toy wrote: > This is a breaking change. We used to have to have a final task that called > finishJSTest(). It's not clear to me that audit should always automatically do > this. Not sure why this is a breaking change. It does not break anything. It just does one more step when the task runner is finished in the case of testharness.
	43 </script>

	44 </body>

	45 </html>

OLD	NEW