Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2212003002: Check that the local frame is not null before instantiating AnimationWorklet. (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that the local frame is not null before instantiating AnimationWorklet. This patch fixes the crash in blink::LocalFrame::document. See https://cluster-fuzz.appspot.com/testcase?key=5879802211074048 for more details. This is simlar to what we already do in WindowPaintWorklet::paintWorklet. BUG=567358, 634253 Committed: https://crrev.com/4f70f4aa155228044960e6521266c22e9f4e5539 Cr-Commit-Position: refs/heads/master@{#409973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-04 17:27:45 UTC) #3
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-04 18:16:04 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-05 01:11:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212003002/1
4 years, 4 months ago (2016-08-05 01:12:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 02:52:06 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 02:53:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f70f4aa155228044960e6521266c22e9f4e5539
Cr-Commit-Position: refs/heads/master@{#409973}

Powered by Google App Engine
This is Rietveld 408576698