Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: components/omnibox/browser/verbatim_match.cc

Issue 2211983002: Remove search::IsQueryExtractionEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_prefetch_non_default
Patch Set: remove more tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/verbatim_match.cc
diff --git a/components/omnibox/browser/verbatim_match.cc b/components/omnibox/browser/verbatim_match.cc
index e4efcf7893472b670801012145185bc5497ce90c..381ba3d2ffa7b7bdbdee3e63dfc3a7fb3d1aa149 100644
--- a/components/omnibox/browser/verbatim_match.cc
+++ b/components/omnibox/browser/verbatim_match.cc
@@ -9,7 +9,6 @@
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_provider_client.h"
#include "components/omnibox/browser/history_url_provider.h"
-#include "components/search/search.h"
#include "url/gurl.h"
AutocompleteMatch VerbatimMatchForURL(
@@ -20,15 +19,12 @@ AutocompleteMatch VerbatimMatchForURL(
int verbatim_relevance) {
DCHECK(!input.text().empty());
AutocompleteMatch match;
- // If query-in-the-omnibox is not enabled (and thus the verbatim match for
- // a URL is guaranteed to be a URL) and the caller already knows where the
- // verbatim match should go and has provided a HistoryURLProvider to aid in
- // its construction, construct the match directly, don't call Classify() on
- // the input. Classify() runs all providers' synchronous passes. Some
- // providers such as HistoryQuick can have a slow synchronous pass on some
- // inputs.
- if (history_url_provider && destination_url.is_valid() &&
- !search::IsQueryExtractionEnabled()) {
+ // If the caller already knows where the verbatim match should go and has
+ // provided a HistoryURLProvider to aid in its construction, construct the
+ // match directly, don't call Classify() on the input. Classify() runs all
+ // providers' synchronous passes. Some providers such as HistoryQuick can
+ // have a slow synchronous pass on some inputs.
+ if (history_url_provider && destination_url.is_valid()) {
match = history_url_provider->SuggestExactInput(
input,
destination_url,

Powered by Google App Engine
This is Rietveld 408576698