Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7090)

Unified Diff: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

Issue 2211983002: Remove search::IsQueryExtractionEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_prefetch_non_default
Patch Set: remove more tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
diff --git a/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc b/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
index fad234dfaf741d64c889d5bef2e55c5e07bfa421..40ba21ae1b0d26f8965b9526aecd5388285c093d 100644
--- a/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
+++ b/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
@@ -347,15 +347,6 @@ TEST_F(InstantSearchPrerendererTest, PrerenderingAllowed) {
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
EXPECT_FALSE(AutocompleteMatch::IsSearchType(url_type_match.type));
EXPECT_FALSE(prerenderer->IsAllowed(url_type_match, active_tab));
-
- // Search results page supports Instant search. InstantSearchPrerenderer is
- // used only when the underlying page doesn't support Instant.
- NavigateAndCommitActiveTab(GURL("https://www.google.com/alt#quux=foo&strk"));
- active_tab = GetActiveWebContents();
- EXPECT_FALSE(
- search::ExtractSearchTermsFromURL(profile(), active_tab->GetURL())
- .empty());
- EXPECT_FALSE(prerenderer->IsAllowed(search_type_match, active_tab));
}
TEST_F(InstantSearchPrerendererTest, UsePrerenderPage) {
@@ -481,13 +472,6 @@ TEST_F(ReuseInstantSearchBasePageTest,
#if !defined(OS_ANDROID)
class TestUsePrerenderPage : public InstantSearchPrerendererTest {
- protected:
- void SetUp() override {
- // Disable query extraction flag in field trials.
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
- "EmbeddedSearch", "Group1 strk:20 query_extraction:0"));
- InstantUnitTestBase::SetUpWithoutQueryExtraction();
- }
};
TEST_F(TestUsePrerenderPage, ExtractSearchTermsAndUsePrerenderPage) {

Powered by Google App Engine
This is Rietveld 408576698