[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(), common().

[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(), common().

BUG=

Committed: https://crrev.com/4b4c354b91bfd7cc01400c1d984fdc634ce68df0
Cr-Commit-Position: refs/heads/master@{#38363}

[bgeron, 2016-08-04 15:34:42]

Description was changed from

==========
[turbofan] Refactor js-inlining.cc to use graph() and jsgraph() uniformly.

BUG=
R=jarin
CC=bmeurer
==========

to

==========
[turbofan] Refactor js-inlining.cc to use graph() and jsgraph() uniformly.

BUG=
==========

[bgeron, 2016-08-04 15:35:26]

Please take a look.

[Benedikt Meurer, 2016-08-05 04:50:36]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-08-05 04:50:37]

LGTM with nit.

https://codereview.chromium.org/2211963002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2211963002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:485:
jsgraph()->javascript()->ConvertReceiver(p.convert_mode()),
Nit: Can you also add a javascript() helper method that returns
jsgraph()->javascript()?

[bgeron, 2016-08-05 08:42:26]

https://codereview.chromium.org/2211963002/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/2211963002/diff/1/src/compiler/js-inlining.cc...
src/compiler/js-inlining.cc:485:
jsgraph()->javascript()->ConvertReceiver(p.convert_mode()),
On 2016/08/05 04:50:37, Benedikt Meurer wrote:
> Nit: Can you also add a javascript() helper method that returns
> jsgraph()->javascript()?

Done.

[bgeron, 2016-08-05 08:42:32]

The CQ bit was checked by bgeron@google.com

[bgeron, 2016-08-05 08:42:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2211963002/#ps20001
(title: "Added JSGraph::javascript()")

[commit-bot: I haz the power, 2016-08-05 08:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bgeron, 2016-08-05 09:02:34]

The CQ bit was unchecked by bgeron@google.com

[bgeron, 2016-08-05 09:06:17]

The CQ bit was checked by bgeron@google.com

[bgeron, 2016-08-05 09:06:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2211963002/#ps40001
(title: "Also do common(), why not.")

[commit-bot: I haz the power, 2016-08-05 09:06:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 09:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 09:08:18]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10389)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10335)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6383)

[bgeron, 2016-08-05 09:16:56]

Description was changed from

==========
[turbofan] Refactor js-inlining.cc to use graph() and jsgraph() uniformly.

BUG=
==========

to

==========
[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(),
common().

BUG=
==========

[bgeron, 2016-08-05 09:29:39]

The CQ bit was checked by bgeron@google.com

[bgeron, 2016-08-05 09:29:40]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2211963002/#ps60001
(title: "Doh.")

[commit-bot: I haz the power, 2016-08-05 09:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 09:53:13]

Description was changed from

==========
[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(),
common().

BUG=
==========

to

==========
[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(),
common().

BUG=
==========

[commit-bot: I haz the power, 2016-08-05 09:53:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 09:54:57]

Description was changed from

==========
[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(),
common().

BUG=
==========

to

==========
[turbofan] Refactor js-inlining.cc to use more graph(), jsgraph(), javascript(),
common().

BUG=

Committed: https://crrev.com/4b4c354b91bfd7cc01400c1d984fdc634ce68df0
Cr-Commit-Position: refs/heads/master@{#38363}
==========

[commit-bot: I haz the power, 2016-08-05 09:54:58]

Patchset 4 (id:??) landed as
https://crrev.com/4b4c354b91bfd7cc01400c1d984fdc634ce68df0
Cr-Commit-Position: refs/heads/master@{#38363}