Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2211893002: [heap] Temporarily do not use size to iterate live object to investigate Win 10 memory regression. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Temporarily do not use size to iterate live object to investigate Win 10 memory regression. BUG=chromium:633537 Committed: https://crrev.com/04fda1f686405a6ec774470be011806cc23a02b0 Cr-Commit-Position: refs/heads/master@{#38369}

Patch Set 1 #

Patch Set 2 : [heap] Temporarily do not use size to iterate live object to investigate Win 10 memory regression. #

Patch Set 3 : remove tests #

Patch Set 4 : remove invalid check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -172 lines) Patch
M src/heap/mark-compact-inl.h View 1 2 3 1 chunk +9 lines, -14 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 1 chunk +0 lines, -158 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
ulan
lgtm
4 years, 4 months ago (2016-08-05 09:28:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211893002/60001
4 years, 4 months ago (2016-08-05 10:54:01 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-05 10:56:02 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 10:58:44 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/04fda1f686405a6ec774470be011806cc23a02b0
Cr-Commit-Position: refs/heads/master@{#38369}

Powered by Google App Engine
This is Rietveld 408576698