Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: Source/wtf/StringExtras.h

Issue 22118002: Move all the HAVE() macros related to string manipulations to wtf/StringExtras.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@timeb
Patch Set: Address review comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/wtf/Platform.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WTF_StringExtras_h 26 #ifndef WTF_StringExtras_h
27 #define WTF_StringExtras_h 27 #define WTF_StringExtras_h
28 28
29 #if OS(UNIX)
30 #define HAVE_STRINGS_H 1
31 #endif
32
33 #if !defined(HAVE_STRNSTR)
34 #if OS(DARWIN) || (OS(FREEBSD) && !defined(__GLIBC__))
35 #define HAVE_STRNSTR 1
36 #endif
37 #endif
38
29 #include <stdarg.h> 39 #include <stdarg.h>
30 #include <stdio.h> 40 #include <stdio.h>
31 #include <string.h> 41 #include <string.h>
32 42
33 #if HAVE(STRINGS_H) 43 #if HAVE(STRINGS_H)
34 #include <strings.h> 44 #include <strings.h>
35 #endif 45 #endif
36 46
37 #if COMPILER(MSVC) 47 #if COMPILER(MSVC)
38 // FIXME: why a COMPILER check instead of OS? also, these should be HAVE checks 48 // FIXME: why a COMPILER check instead of OS? also, these should be HAVE checks
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 for (const char* start = buffer; *start && start + targetLength <= buffer + bufferLength; start++) { 101 for (const char* start = buffer; *start && start + targetLength <= buffer + bufferLength; start++) {
92 if (*start == *target && strncmp(start + 1, target + 1, targetLength - 1 ) == 0) 102 if (*start == *target && strncmp(start + 1, target + 1, targetLength - 1 ) == 0)
93 return const_cast<char*>(start); 103 return const_cast<char*>(start);
94 } 104 }
95 return 0; 105 return 0;
96 } 106 }
97 107
98 #endif 108 #endif
99 109
100 #endif // WTF_StringExtras_h 110 #endif // WTF_StringExtras_h
OLDNEW
« no previous file with comments | « Source/wtf/Platform.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698