Issue 22118002: Move all the HAVE() macros related to string manipulations to wtf/StringExtras.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22118002: Move all the HAVE() macros related to string manipulations to wtf/StringExtras.h. (Closed)

Created:
7 years, 4 months ago by lgombos

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez

Base URL:
https://chromium.googlesource.com/chromium/blink.git@timeb

Visibility:
Public.

More Reviews

Description

Move all the HAVE() macros related to string manipulations to wtf/StringExtras.h. The goal of this refactoring is to reduce the scope of these macros and only make them visible to files where it is used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155905

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Address review comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	Source/wtf/Platform.h	View	1 2	2 chunks	+0 lines, -7 lines	0 comments	Download
	M	Source/wtf/StringExtras.h	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lgombos

This brings us a step closer to make all the global macros in Platform.h smaller ...

7 years, 4 months ago (2013-08-05 00:34:19 UTC) #1

abarth-chromium

lgtm https://codereview.chromium.org/22118002/diff/18001/Source/wtf/StringExtras.h File Source/wtf/StringExtras.h (right): https://codereview.chromium.org/22118002/diff/18001/Source/wtf/StringExtras.h#newcode29 Source/wtf/StringExtras.h:29: #include "wtf/Platform.h" You don't need to include Platform.h ...

7 years, 4 months ago (2013-08-05 21:57:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/22118002/29001

7 years, 4 months ago (2013-08-10 19:53:07 UTC) #3

Message was sent while issue was closed.

Change committed as 155905

Expand Messages | Collapse Messages