Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2211783003:
Track input latency while starting a ServiceWorker for a navigation hint. (Closed)
|
Created:
4 years, 4 months ago by horo Modified:
4 years, 4 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, dtapuska+chromiumwatch_chromium.org, kinuko+serviceworker, nhiroki, asvitkine+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrack input latency while starting a ServiceWorker for a navigation hint.
This CL introduces these new UMAs:
- Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask
- Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask
BUG=616502, 638827
Committed: https://crrev.com/f5d309f062b41c29a2adbcc469a967b95f61dca3
Cr-Commit-Position: refs/heads/master@{#412998}
Patch Set 1 #Patch Set 2 : add test #
Total comments: 2
Patch Set 3 : use _ #Patch Set 4 : add comment #
Messages
Total messages: 61 (48 generated)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Track input latency while starting a ServiceWorker for a navigation hint. BUG=616502 ========== to ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #5 (id:80001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
horo@chromium.org changed reviewers: + shimazu@chromium.org
shimazu@ Could you please review this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2211783003/diff/120001/content/browser/render... File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc (right): https://codereview.chromium.org/2211783003/diff/120001/content/browser/render... content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:122: "Event.Latency.TouchToFirstScrollUpdateSwapBegin." According the top of histograms.xml, I thought "...SwapBegin_" is better here instead of "...SwapBegin.", but the unittest works... Is there difference between the two? https://cs.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?...
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2211783003/diff/120001/content/browser/render... File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc (right): https://codereview.chromium.org/2211783003/diff/120001/content/browser/render... content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:122: "Event.Latency.TouchToFirstScrollUpdateSwapBegin." On 2016/08/16 09:46:21, shimazu wrote: > According the top of histograms.xml, I thought "...SwapBegin_" is better here > instead of "...SwapBegin.", but the unittest works... Is there difference > between the two? > > https://cs.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?... I don't know well about the regulations of what separator should be used. But "_" is a default value. So I should probably use "_". I uploaded Patch Set 3.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
horo@chromium.org changed reviewers: + tdresser@chromium.org
tdresser@ Could you please review this?
Are we going to keep this around for a long time, or is this a temporary metric? If it's temporary, let's make sure there's a bug to remove it (with a target milestone), and a TODO. If it's permanent, we might want to tell the LatencyInfo object about is_running_navigation_hint_task, instead of passing it directly to OnFrameSwapped. Our general model is that LatencyInfo rolls around the codebase, picking up bits of data, and then RWHLT processes all the data. Passing a separate bool in is a bit abnormal.
Description was changed from ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502 ========== to ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502, 638827 ==========
The CQ bit was checked by horo@chromium.org to run a CQ dry run
On 2016/08/17 12:47:08, tdresser wrote: > Are we going to keep this around for a long time, or is this a temporary metric? > > If it's temporary, let's make sure there's a bug to remove it (with a target > milestone), and a TODO. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thanks.
horo@chromium.org changed reviewers: + mpearson@chromium.org
mpearson@ Could you please review histograms.xml?
histograms.xml lgtm
The CQ bit was checked by horo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shimazu@chromium.org Link to the patchset: https://codereview.chromium.org/2211783003/#ps160001 (title: "add comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502, 638827 ========== to ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502, 638827 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502, 638827 ========== to ========== Track input latency while starting a ServiceWorker for a navigation hint. This CL introduces these new UMAs: - Event.Latency.TouchToFirstScrollUpdateSwapBegin.IsRunningNavigationHintTask - Event.Latency.TouchToScrollUpdateSwapBegin.IsRunningNavigationHintTask BUG=616502, 638827 Committed: https://crrev.com/f5d309f062b41c29a2adbcc469a967b95f61dca3 Cr-Commit-Position: refs/heads/master@{#412998} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f5d309f062b41c29a2adbcc469a967b95f61dca3 Cr-Commit-Position: refs/heads/master@{#412998} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
