Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: runtime/vm/instructions_arm_test.cc

Issue 221173011: Simplify handling of IC and megamorphic cache misses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
11 #include "vm/stub_code.h" 11 #include "vm/stub_code.h"
12 #include "vm/unit_test.h" 12 #include "vm/unit_test.h"
13 13
14 namespace dart { 14 namespace dart {
15 15
16 #define __ assembler-> 16 #define __ assembler->
17 17
18 ASSEMBLER_TEST_GENERATE(Call, assembler) { 18 ASSEMBLER_TEST_GENERATE(Call, assembler) {
19 __ BranchLinkPatchable(&StubCode::InstanceFunctionLookupLabel()); 19 __ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel());
20 __ Ret(); 20 __ Ret();
21 } 21 }
22 22
23 23
24 ASSEMBLER_TEST_RUN(Call, test) { 24 ASSEMBLER_TEST_RUN(Call, test) {
25 // The return address, which must be the address of an instruction contained 25 // The return address, which must be the address of an instruction contained
26 // in the code, points to the Ret instruction above, i.e. one instruction 26 // in the code, points to the Ret instruction above, i.e. one instruction
27 // before the end of the code buffer. 27 // before the end of the code buffer.
28 CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize, 28 CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize,
29 test->code()); 29 test->code());
30 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 30 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
31 call.TargetAddress()); 31 call.TargetAddress());
32 } 32 }
33 33
34 34
35 ASSEMBLER_TEST_GENERATE(Jump, assembler) { 35 ASSEMBLER_TEST_GENERATE(Jump, assembler) {
36 __ BranchPatchable(&StubCode::InstanceFunctionLookupLabel()); 36 __ BranchPatchable(&StubCode::InvokeDartCodeLabel());
37 __ BranchPatchable(&StubCode::AllocateArrayLabel()); 37 __ BranchPatchable(&StubCode::AllocateArrayLabel());
38 } 38 }
39 39
40 40
41 ASSEMBLER_TEST_RUN(Jump, test) { 41 ASSEMBLER_TEST_RUN(Jump, test) {
42 const Code& code = test->code(); 42 const Code& code = test->code();
43 const Instructions& instrs = Instructions::Handle(code.instructions()); 43 const Instructions& instrs = Instructions::Handle(code.instructions());
44 bool status = 44 bool status =
45 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()), 45 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
46 instrs.size(), 46 instrs.size(),
47 VirtualMemory::kReadWrite); 47 VirtualMemory::kReadWrite);
48 EXPECT(status); 48 EXPECT(status);
49 JumpPattern jump1(test->entry(), test->code()); 49 JumpPattern jump1(test->entry(), test->code());
50 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 50 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
51 jump1.TargetAddress()); 51 jump1.TargetAddress());
52 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(), 52 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
53 test->code()); 53 test->code());
54 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 54 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
55 jump2.TargetAddress()); 55 jump2.TargetAddress());
56 uword target1 = jump1.TargetAddress(); 56 uword target1 = jump1.TargetAddress();
57 uword target2 = jump2.TargetAddress(); 57 uword target2 = jump2.TargetAddress();
58 jump1.SetTargetAddress(target2); 58 jump1.SetTargetAddress(target2);
59 jump2.SetTargetAddress(target1); 59 jump2.SetTargetAddress(target1);
60 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 60 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
61 jump1.TargetAddress()); 61 jump1.TargetAddress());
62 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 62 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
63 jump2.TargetAddress()); 63 jump2.TargetAddress());
64 } 64 }
65 65
66 66
67 #if defined(USING_SIMULATOR) 67 #if defined(USING_SIMULATOR)
68 ASSEMBLER_TEST_GENERATE(JumpARMv6, assembler) { 68 ASSEMBLER_TEST_GENERATE(JumpARMv6, assembler) {
69 // ARMv7 is the default. 69 // ARMv7 is the default.
70 HostCPUFeatures::set_arm_version(ARMv6); 70 HostCPUFeatures::set_arm_version(ARMv6);
71 __ BranchPatchable(&StubCode::InstanceFunctionLookupLabel()); 71 __ BranchPatchable(&StubCode::InvokeDartCodeLabel());
72 __ BranchPatchable(&StubCode::AllocateArrayLabel()); 72 __ BranchPatchable(&StubCode::AllocateArrayLabel());
73 HostCPUFeatures::set_arm_version(ARMv7); 73 HostCPUFeatures::set_arm_version(ARMv7);
74 } 74 }
75 75
76 76
77 ASSEMBLER_TEST_RUN(JumpARMv6, test) { 77 ASSEMBLER_TEST_RUN(JumpARMv6, test) {
78 HostCPUFeatures::set_arm_version(ARMv6); 78 HostCPUFeatures::set_arm_version(ARMv6);
79 const Code& code = test->code(); 79 const Code& code = test->code();
80 const Instructions& instrs = Instructions::Handle(code.instructions()); 80 const Instructions& instrs = Instructions::Handle(code.instructions());
81 bool status = 81 bool status =
82 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()), 82 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
83 instrs.size(), 83 instrs.size(),
84 VirtualMemory::kReadWrite); 84 VirtualMemory::kReadWrite);
85 EXPECT(status); 85 EXPECT(status);
86 JumpPattern jump1(test->entry(), test->code()); 86 JumpPattern jump1(test->entry(), test->code());
87 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 87 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
88 jump1.TargetAddress()); 88 jump1.TargetAddress());
89 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(), 89 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
90 test->code()); 90 test->code());
91 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 91 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
92 jump2.TargetAddress()); 92 jump2.TargetAddress());
93 uword target1 = jump1.TargetAddress(); 93 uword target1 = jump1.TargetAddress();
94 uword target2 = jump2.TargetAddress(); 94 uword target2 = jump2.TargetAddress();
95 jump1.SetTargetAddress(target2); 95 jump1.SetTargetAddress(target2);
96 jump2.SetTargetAddress(target1); 96 jump2.SetTargetAddress(target1);
97 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 97 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
98 jump1.TargetAddress()); 98 jump1.TargetAddress());
99 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 99 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
100 jump2.TargetAddress()); 100 jump2.TargetAddress());
101 HostCPUFeatures::set_arm_version(ARMv7); 101 HostCPUFeatures::set_arm_version(ARMv7);
102 } 102 }
103 #endif 103 #endif
104 104
105 } // namespace dart 105 } // namespace dart
106 106
107 #endif // defined TARGET_ARCH_ARM 107 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698