Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2211713002: Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h (Closed)

Created:
4 years, 4 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, wjmaclean, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, mmenke, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h Contrary to previous attempt at: https://chromium.googlesource.com/chromium/src.git/+/68c6f2ce16d9807b5cb82679099c82c40f39e911 RenderFrameMessageFilter is on the IO thread, and is a BrowserAssociatedInterface, so will maintain the ordering of the resource request and the zoom level request. See also https://codereview.chromium.org/2167513003. BUG=609607 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/d4423d511f18f4b0d2e94cf17bf6043bee449c55 Cr-Commit-Position: refs/heads/master@{#410417}

Patch Set 1 : on io in renderframemessagefilter #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : override #

Total comments: 2

Patch Set 5 : tests #

Patch Set 6 : doc #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -102 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 1 2 3 4 5 6 7 4 chunks +22 lines, -1 line 0 comments Download
M content/browser/host_zoom_map_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/async_revalidation_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_message_filter.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/browser/loader/resource_message_filter.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/common/render_frame_message_filter.mojom View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +26 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 2 3 4 5 6 7 8 2 chunks +30 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -26 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 6 7 8 4 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 49 (39 generated)
scottmg
jam: overall tsepez: _messages and .mojom
4 years, 4 months ago (2016-08-05 19:28:51 UTC) #11
Tom Sepez
mojom/messages LGTM
4 years, 4 months ago (2016-08-05 20:03:56 UTC) #17
jam
lgtm https://codereview.chromium.org/2211713002/diff/80001/content/common/render_frame_message_filter.mojom File content/common/render_frame_message_filter.mojom (right): https://codereview.chromium.org/2211713002/diff/80001/content/common/render_frame_message_filter.mojom#newcode21 content/common/render_frame_message_filter.mojom:21: GetHostZoomLevel(int32 render_frame_id, url.mojom.Url url) nit: document
4 years, 4 months ago (2016-08-05 20:05:51 UTC) #18
scottmg
https://codereview.chromium.org/2211713002/diff/80001/content/common/render_frame_message_filter.mojom File content/common/render_frame_message_filter.mojom (right): https://codereview.chromium.org/2211713002/diff/80001/content/common/render_frame_message_filter.mojom#newcode21 content/common/render_frame_message_filter.mojom:21: GetHostZoomLevel(int32 render_frame_id, url.mojom.Url url) On 2016/08/05 20:05:51, jam wrote: ...
4 years, 4 months ago (2016-08-05 20:08:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211713002/160001
4 years, 4 months ago (2016-08-06 00:02:04 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/275438)
4 years, 4 months ago (2016-08-06 00:43:41 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211713002/180001
4 years, 4 months ago (2016-08-08 19:49:55 UTC) #44
commit-bot: I haz the power
Committed patchset #9 (id:180001)
4 years, 4 months ago (2016-08-08 20:12:05 UTC) #46
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/d4423d511f18f4b0d2e94cf17bf6043bee449c55 Cr-Commit-Position: refs/heads/master@{#410417}
4 years, 4 months ago (2016-08-08 20:13:27 UTC) #48
scottmg
4 years, 4 months ago (2016-08-09 16:43:36 UTC) #49
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/2222403002/ by scottmg@chromium.org.

The reason for reverting is: Looks like there's a race during initialization on
chromeos https://bugs.chromium.org/p/chromium/issues/detail?id=635832#c3.

Powered by Google App Engine
This is Rietveld 408576698