Issue 2211693002: Update navigator.share API to match draft specs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2211693002: Update navigator.share API to match draft specs. (Closed)

Created:
4 years, 4 months ago by Matt Giuca

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, Dirk Pranke, haraken

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Update navigator.share API to match draft specs. WIP CL; DO NOT SUBMIT. BUG=634198

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -15 lines)			Patch
M	third_party/WebKit/Source/modules/modules.gypi	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webshare/NavigatorShare.idl	View	1 chunk	+1 line, -6 lines	0 comments	Download
A +	third_party/WebKit/Source/modules/webshare/ShareData.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
A +	third_party/WebKit/Source/modules/webshare/ShareData.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	third_party/WebKit/Source/modules/webshare/ShareData.idl	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Matt Giuca

4 years, 4 months ago (2016-08-08 04:09:41 UTC) #2

Message was sent while issue was closed.

This was already done by sammc in https://crrev.com/410297.