[perf] Disable legacy page_cycler on all platforms except for Chrome OS

tools/perf/benchmarks/page_cycler.py

Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index e8883146a8476a09a6bfa7116e54771e2f282e17..3e6bbcd41e6e456993f4193210debac710a2353c 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -9,6 +9,7 @@ import page_sets
 from telemetry import benchmark
 
 
+@benchmark.Enabled('chromeos')

[petrcermak, 2016/08/04 17:17:17]

All subclasses will automatically inherit this.

[nednguyen, 2016/08/04 17:34:37]

This is actually a bug, not a feature:
https://bugs.chromium.org/p/chromium/issues/detail?id=568333

Let go with overridding the SHouldDIsable way to be safe.

[petrcermak, 2016/08/05 10:21:40]

Done.

 class _PageCycler(perf_benchmark.PerfBenchmark):
   options = {'pageset_repeat': 6}
   cold_load_percent = 50  # % of page visits for which a cold load is forced
@@ -35,7 +36,6 @@ class _PageCycler(perf_benchmark.PerfBenchmark):
         report_speed_index=options.report_speed_index)
 
 
-@benchmark.Enabled('chromeos')
 class PageCyclerIntlArFaHe(_PageCycler):
   """Page load time for a variety of pages in Arabic, Farsi and Hebrew.
 
@@ -48,7 +48,6 @@ class PageCyclerIntlArFaHe(_PageCycler):
     return 'page_cycler.intl_ar_fa_he'
 
 
-@benchmark.Enabled('chromeos')
 class PageCyclerIntlEsFrPtBr(_PageCycler):
   """Page load time for a pages in Spanish, French and Brazilian Portuguese.
 
@@ -73,7 +72,6 @@ class PageCyclerIntlHiRu(_PageCycler):
     return 'page_cycler.intl_hi_ru'
 
 
-@benchmark.Enabled('chromeos')
 class PageCyclerIntlJaZh(_PageCycler):
   """Page load time benchmark for a variety of pages in Japanese and Chinese.
 
@@ -107,16 +105,7 @@ class PageCyclerIntlKoThVi(_PageCycler):
   def Name(cls):
     return 'page_cycler.intl_ko_th_vi'
 
-  @classmethod
-  def ShouldDisable(cls, possible_browser):
-    # http://crbug.com/597656 (Android Nexus 5X).
-    # http://crbug.com/605543 (Mac Snow Leopard).
-    return (possible_browser.browser_type == 'reference' and (
-              possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
-              possible_browser.platform.GetOSVersionName() == 'snowleopard'))
-
 
-@benchmark.Disabled('android')  # crbug.com/357326
 class PageCyclerToughLayoutCases(_PageCycler):
   """Page loading for the slowest layouts observed in the Alexa top 1 million.
 
@@ -138,16 +127,6 @@ class PageCyclerTypical25(_PageCycler):
   options = {'pageset_repeat': 3}
 
   @classmethod
-  def ShouldDisable(cls, possible_browser):  # http://crbug.com/597656
-    if (possible_browser.browser_type == 'reference' and
-        possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
-      return True
-    # http://crbug.com/616781
-    if possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead':
-      return True
-    return False
-
-  @classmethod
   def Name(cls):
     return 'page_cycler.typical_25'
 
@@ -155,7 +134,6 @@ class PageCyclerTypical25(_PageCycler):
     return page_sets.Typical25PageSet(run_no_page_interactions=True)
 
 
-@benchmark.Disabled('reference', 'android')
 class PageCyclerBasicOopifIsolated(_PageCycler):
   """ A benchmark measuring performance of out-of-process iframes. """
   page_set = page_sets.OopifBasicPageSet
@@ -176,7 +154,3 @@ class PageCyclerBasicOopif(_PageCycler):
   @classmethod
   def Name(cls):
     return 'page_cycler.basic_oopif'
-
-  @classmethod
-  def ShouldDisable(cls, possible_browser):
-    return cls.IsSvelte(possible_browser)  # http://crbug.com/607657