[perf] Disable legacy page_cycler on all platforms except for Chrome OS

[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310, 611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com

Committed: https://crrev.com/2f535b4682cf74ffd1c3b1afd02df602e70519a6
Cr-Commit-Position: refs/heads/master@{#410048}

[petrcermak, 2016-08-04 17:03:40]

Description was changed from

==========
[perf] Disable page_cycler.intl_hi_ru and page_cycler.intl_ko_th_vi on
android-webview

Rationale: The benchmarks are failing a lot on Android Nexus5X WebView
Perf (2) (8 and 14 failures out of 20 last runs respectively).

BUG=634310
==========

to

==========
[perf] Disable page_cycler.intl_hi_ru and page_cycler.intl_ko_th_vi on
android-webview

Rationale: The benchmarks are failing a lot on Android Nexus5X WebView
Perf (2) (8 and 14 failures out of 20 last runs respectively).

BUG=634310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[petrcermak, 2016-08-04 17:04:04]

Description was changed from

==========
[perf] Disable page_cycler.intl_hi_ru and page_cycler.intl_ko_th_vi on
android-webview

Rationale: The benchmarks are failing a lot on Android Nexus5X WebView
Perf (2) (8 and 14 failures out of 20 last runs respectively).

BUG=634310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
[perf] Disable page_cycler.intl_hi_ru and page_cycler.intl_ko_th_vi on
android-webview

Rationale: The benchmarks are failing a lot on Android Nexus5X WebView
Perf (2) (8 and 14 failures out of 20 last runs respectively).

BUG=634310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

[petrcermak, 2016-08-04 17:04:24]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-08-04 17:04:24]

PTAL.

Thanks,
Petr

[petrcermak, 2016-08-04 17:04:29]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:05:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-08-04 17:07:03]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2016-08-04 17:08:09]

On 2016/08/04 17:05:22, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Since you are already here, can you override the base class
_PageCYcler.ShouldDisable(..) so that we only run page_cycler on ChromeOs? We no
longer care about legacy PageCYcler on non ChromeOS platform.

[nednguyen, 2016-08-04 17:08:27]

nednguyen@google.com changed reviewers:
+ kouhei@chromium.org

[nednguyen, 2016-08-04 17:09:21]

On 2016/08/04 17:08:09, nednguyen wrote:
> On 2016/08/04 17:05:22, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Since you are already here, can you override the base class
> _PageCYcler.ShouldDisable(..) so that we only run page_cycler on ChromeOs? We
no
> longer care about legacy PageCYcler on non ChromeOS platform.

The cover bug for removing legacy PageCycler & replace them with PCV2 is
https://bugs.chromium.org/p/chromium/issues/detail?id=611329

[petrcermak, 2016-08-04 17:17:02]

Description was changed from

==========
[perf] Disable page_cycler.intl_hi_ru and page_cycler.intl_ko_th_vi on
android-webview

Rationale: The benchmarks are failing a lot on Android Nexus5X WebView
Perf (2) (8 and 14 failures out of 20 last runs respectively).

BUG=634310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

to

==========
[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310,611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

[petrcermak, 2016-08-04 17:17:17]

sgtm. PTAL.

Thanks,
Petr

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:12: @benchmark.Enabled('chromeos')
All subclasses will automatically inherit this.

[nednguyen, 2016-08-04 17:34:37]

lgtm

Thanks for removing existing disabling logic!

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:12: @benchmark.Enabled('chromeos')
On 2016/08/04 17:17:17, petrcermak wrote:
> All subclasses will automatically inherit this.

This is actually a bug, not a feature:
https://bugs.chromium.org/p/chromium/issues/detail?id=568333

Let go with overridding the SHouldDIsable way to be safe.

[petrcermak, 2016-08-04 17:47:59]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-04 17:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2211673003/#ps40001
(title: "Use ShouldDisable")

[commit-bot: I haz the power, 2016-08-04 17:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-08-04 18:38:40]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-08-04 18:39:00]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-04 18:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 19:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:50:59]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)
  linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)
  winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build
URL)

[petrcermak, 2016-08-05 09:03:57]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-05 09:04:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 09:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 09:08:15]

Try jobs failed on following builders:
  mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)

[petrcermak, 2016-08-05 09:11:42]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-05 09:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2211673003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-05 09:11:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-08-05 10:21:41]

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/2211673003/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:12: @benchmark.Enabled('chromeos')
On 2016/08/04 17:34:37, nednguyen wrote:
> On 2016/08/04 17:17:17, petrcermak wrote:
> > All subclasses will automatically inherit this.
> 
> This is actually a bug, not a feature:
> https://bugs.chromium.org/p/chromium/issues/detail?id=568333
> 
> Let go with overridding the SHouldDIsable way to be safe.

Done.

[commit-bot: I haz the power, 2016-08-05 10:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 10:24:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nednguyen, 2016-08-05 10:32:08]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-08-05 10:32:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 13:42:37]

Description was changed from

==========
[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310,611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

to

==========
[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310,611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

[commit-bot: I haz the power, 2016-08-05 13:42:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 13:44:30]

Description was changed from

==========
[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310,611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
==========

to

==========
[perf] Disable legacy page_cycler on all platforms except for Chrome OS

Rationale: It has been superseded by Page Cycler v2.

BUG=634310,611329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com

Committed: https://crrev.com/2f535b4682cf74ffd1c3b1afd02df602e70519a6
Cr-Commit-Position: refs/heads/master@{#410048}
==========

[commit-bot: I haz the power, 2016-08-05 13:44:31]

Patchset 4 (id:??) landed as
https://crrev.com/2f535b4682cf74ffd1c3b1afd02df602e70519a6
Cr-Commit-Position: refs/heads/master@{#410048}