Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2211633003: [turbofan] Basic reductions of 64-bit machine operators. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Basic reductions of 64-bit machine operators. Only basic things for now, but enough, for example, to emit mov rax, [rax+0xc] instead of mov rax, 0x3 mov rdx, [rdx+rax*4] on x64. BUG= Committed: https://crrev.com/7eee14448085939587617328d36657bb1b8053a2 Cr-Commit-Position: refs/heads/master@{#38338}

Patch Set 1 #

Patch Set 2 : Forgot the tests for Word64 shifts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -6 lines) Patch
M src/compiler/machine-operator-reducer.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 7 chunks +65 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 8 chunks +108 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
epertoso
4 years, 4 months ago (2016-08-04 10:48:00 UTC) #5
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-04 11:03:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211633003/20001
4 years, 4 months ago (2016-08-04 12:18:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 12:36:48 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 12:37:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7eee14448085939587617328d36657bb1b8053a2
Cr-Commit-Position: refs/heads/master@{#38338}

Powered by Google App Engine
This is Rietveld 408576698