Add AssignmentSource to BlimpClientContextImpl

blimp/client/core/dummy_blimp_client_context.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_CORE_DUMMY_BLIMP_CLIENT_CONTEXT_H_
 #define BLIMP_CLIENT_CORE_DUMMY_BLIMP_CLIENT_CONTEXT_H_
 
 #include "base/macros.h"
 #include "blimp/client/public/blimp_client_context.h"
 #include "blimp/client/public/contents/blimp_contents.h"
 
 namespace blimp {
 namespace client {
 
 // A dummy implementation of the BlimpClientContext.

[Kevin M, 2016/08/04 17:44:17]

Already understood by the class name. ;)

What's it used for?

nit: If this is basically a null object, I recommend calling it a
NullBlimpClientContext.

[nyquist, 2016/08/05 21:22:39]

Tried to clarify how to get to this class and why it is sometimes in use in the
comment.

I did not do the rename for now though. I'd be OK with doing that in a follow-up
CL if you want me to.

 class DummyBlimpClientContext : public BlimpClientContext {
  public:
   DummyBlimpClientContext();
   ~DummyBlimpClientContext() override;
 
   // BlimpClientContext implementation.
   void SetDelegate(BlimpClientContextDelegate* delegate) override;
   std::unique_ptr<BlimpContents> CreateBlimpContents() override;
+  void Connect(const std::string& client_auth_token) override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DummyBlimpClientContext);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_CORE_DUMMY_BLIMP_CLIENT_CONTEXT_H_