Add AssignmentSource to BlimpClientContextImpl

blimp/client/core/dummy_blimp_client_context.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/dummy_blimp_client_context.h"
 
 #include "base/memory/ref_counted.h"
 #include "base/single_thread_task_runner.h"
 
 #if defined(OS_ANDROID)
 #include "blimp/client/core/android/dummy_blimp_client_context_android.h"
 #endif  // OS_ANDROID
 
 namespace blimp {
 namespace client {
 
 // This function is declared in //blimp/client/public/blimp_client_context.h,

[Kevin M, 2016/08/04 17:44:17]

This comment doesn't really add any more context than is already communicated by
the code itself.

[nyquist, 2016/08/05 21:22:38]

It does mention the other place the method is implemented. Now, with the updated
comment in the header file, would you be OK with keeping it? Or would you want
me to add more context here as well, or just remove it?

 // and either this function or the one in
 // //blimp/client/core/blimp_client_context_impl.cc should be linked in to
 // any binary using BlimpClientContext::Create.
 // static
 BlimpClientContext* BlimpClientContext::Create(
-    scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner) {
+    scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,
+    scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner) {
 #if defined(OS_ANDROID)
   return new DummyBlimpClientContextAndroid();
 #else
   return new DummyBlimpClientContext();
 #endif  // defined(OS_ANDROID)
 }
 
 DummyBlimpClientContext::DummyBlimpClientContext() : BlimpClientContext() {}
 
 DummyBlimpClientContext::~DummyBlimpClientContext() {}
 
 void DummyBlimpClientContext::SetDelegate(
     BlimpClientContextDelegate* delegate) {}
 
 std::unique_ptr<BlimpContents> DummyBlimpClientContext::CreateBlimpContents() {
   return nullptr;
 }
 
+void DummyBlimpClientContext::Connect(const std::string& client_auth_token) {}

[David Trainor- moved to gerrit, 2016/08/04 16:15:51]

NOTREACHED() maybe?

[nyquist, 2016/08/05 21:22:38]

Done. I wasn't sure whether we wanted to guard the call to Connect() in the
embedder itself, or just make it a no-op.

+
 }  // namespace client
 }  // namespace blimp