runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart - Issue 2211603002: Centralized event streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

Issue 2211603002: Centralized event streams (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merged with master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.dart ('k') | runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart b/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

index e6b3bc2552dc3fac29f4a995dad198c58e248b94..f09ed32f75b82945649de279fb26e3378194e86c 100644

--- a/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

+++ b/runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.dart

@@ -4,23 +4,19 @@

import 'dart:html';

import 'dart:async';

import 'package:unittest/unittest.dart';

-import 'package:observatory/models.dart';

-import 'package:observatory/mocks.dart';

import 'package:observatory/src/elements/nav/notify_exception.dart';

+import '../../mocks.dart';

main() {

NavNotifyExceptionElement.tag.ensureRegistration();

- final ConnectionException exception =

- new ConnectionExceptionMock(message: 'message');

+ final exception = new ConnectionExceptionMock(message: 'message');

test('instantiation', () {

- final NavNotifyExceptionElement e =

- new NavNotifyExceptionElement(exception);

+ final e = new NavNotifyExceptionElement(exception);

expect(e, isNotNull, reason: 'element correctly created');

});

test('elements created after attachment', () async {

- final NavNotifyExceptionElement e =

- new NavNotifyExceptionElement(exception);

+ final e = new NavNotifyExceptionElement(exception);

document.body.append(e);

await e.onRendered.first;

expect(e.children.length, isNonZero, reason: 'has elements');