runtime/observatory/lib/src/elements/source_link.dart - Issue 2211603002: Centralized event streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/source_link.dart

Issue 2211603002: Centralized event streams (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merged with master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/source_link.dart

diff --git a/runtime/observatory/lib/src/elements/source_link.dart b/runtime/observatory/lib/src/elements/source_link.dart

index 02eec26bf8dee9b5dd9160c4ff850cead1ae5e01..110b8e1d19134ee8ee3cecb7b4e8946db24cec0d 100644

--- a/runtime/observatory/lib/src/elements/source_link.dart

+++ b/runtime/observatory/lib/src/elements/source_link.dart

@@ -44,16 +44,19 @@ class SourceLinkElement extends HtmlElement implements Renderable {

@override

void attached() {

super.attached();

- assert(location != null);

- _r.enable();

_repository.get(_location.script.id).then((script) {

_script = script;

_r.dirty();

});

+ _r.enable();

}

@override

- void detached() { super.detached(); children = []; _r.disable(notify: true); }

+ void detached() {

+ super.detached();

+ children = [];

+ _r.disable(notify: true);

+ }

Future render() async {

if (_script == null) {