Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: runtime/observatory/lib/src/elements/error_ref_wrapper.dart

Issue 2211603002: Centralized event streams (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with master Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/error_ref_wrapper.dart
diff --git a/runtime/observatory/lib/src/elements/error_ref_wrapper.dart b/runtime/observatory/lib/src/elements/error_ref_wrapper.dart
index 4efe9397787550a138caed7b097d356d81570be2..50f8b9a7c7c254395cad16e2af5ce7ec8377ac2a 100644
--- a/runtime/observatory/lib/src/elements/error_ref_wrapper.dart
+++ b/runtime/observatory/lib/src/elements/error_ref_wrapper.dart
@@ -5,8 +5,7 @@
import 'dart:html';
import 'package:observatory/app.dart';
-import 'package:observatory/mocks.dart' show ErrorRefMock;
-import 'package:observatory/service_html.dart' show ServiceMap, DartError;
+import 'package:observatory/service.dart';
import 'package:observatory/src/elements/error_ref.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
import 'package:observatory/src/elements/shims/binding.dart';
@@ -19,9 +18,14 @@ class ErrorRefElementWrapper extends HtmlElement {
static const tag = const Tag<ErrorRefElementWrapper>('error-ref');
- ServiceMap _error;
- ServiceMap get ref => _error;
- void set ref(ServiceMap ref) { _error = ref; render(); }
+ DartError _error;
+
+ DartError get ref => _error;
+
+ void set ref(DartError value) {
+ _error = value;
+ render();
+ }
ErrorRefElementWrapper.created() : super.created() {
binder.registerCallback(this);
@@ -37,42 +41,24 @@ class ErrorRefElementWrapper extends HtmlElement {
void render() {
shadowRoot.children = [];
- if (_error == null) return;
-
- if (ref is Map) {
- shadowRoot.children = [
- new StyleElement()
- ..text = '''
- error-ref-wrapped > pre {
- background-color: #f5f5f5;
- border: 1px solid #ccc;
- padding: 10px;
- font-family: consolas, courier, monospace;
- font-size: 1em;
- line-height: 1.2em;
- white-space: pre;
- }
- ''',
- new ErrorRefElement(new ErrorRefMock(message: ref['message']))
- ];
- } else {
- shadowRoot.children = [
- new StyleElement()
- ..text = '''
- error-ref-wrapped > pre {
- background-color: #f5f5f5;
- border: 1px solid #ccc;
- padding: 10px;
- font-family: consolas, courier, monospace;
- font-size: 1em;
- line-height: 1.2em;
- white-space: pre;
- }
- ''',
- new ErrorRefElement(
- new ErrorRefMock(message: (ref as DartError).message),
- queue: ObservatoryApplication.app.queue)
- ];
+ if (_error == null) {
+ return;
}
+
+ shadowRoot.children = [
+ new StyleElement()
+ ..text = '''
+ error-ref-wrapped > pre {
+ background-color: #f5f5f5;
+ border: 1px solid #ccc;
+ padding: 10px;
+ font-family: consolas, courier, monospace;
+ font-size: 1em;
+ line-height: 1.2em;
+ white-space: pre;
+ }
+ ''',
+ new ErrorRefElement(_error, queue: ObservatoryApplication.app.queue)
+ ];
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/error_ref.dart ('k') | runtime/observatory/lib/src/elements/flag_list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698