Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: runtime/observatory/lib/src/app/notification.dart

Issue 2211603002: Centralized event streams (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with master Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/event.dart ('k') | runtime/observatory/lib/src/app/page.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/notification.dart
diff --git a/runtime/observatory/lib/src/app/notification.dart b/runtime/observatory/lib/src/app/notification.dart
index b95c34e226f5065b79d345fd63ff4ab98acd0d15..140e0dce5e2cbb99e7d43b40a07d487ce564ec04 100644
--- a/runtime/observatory/lib/src/app/notification.dart
+++ b/runtime/observatory/lib/src/app/notification.dart
@@ -14,102 +14,4 @@ class ExceptionNotification implements M.ExceptionNotification {
class EventNotification implements M.EventNotification {
final M.Event event;
EventNotification(this.event);
- factory EventNotification.fromServiceEvent(ServiceEvent event) {
- M.Event e;
- switch(event.kind) {
- case ServiceEvent.kVMUpdate:
- e = new VMUpdateEventMock(timestamp: event.timestamp, vm: event.vm);
- break;
- case ServiceEvent.kIsolateStart:
- e = new IsolateStartEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kIsolateRunnable:
- e = new IsolateRunnableEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kIsolateExit:
- e = new IsolateExitEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kIsolateUpdate:
- e = new IsolateUpdateEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kIsolateReload:
- // TODO(bernaschina) add error: realoadError.
- e = new IsolateRealodEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kServiceExtensionAdded:
- e = new ServiceExtensionAddedEventMock(timestamp: event.timestamp,
- isolate: event.isolate, extensionRPC: event.extensionRPC);
- break;
- case ServiceEvent.kPauseStart:
- e = new PauseStartEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kPauseExit:
- e = new PauseExitEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kPauseBreakpoint:
- // TODO(cbernaschina) add pauseBreakpoints.
- e = new PauseBreakpointEventMock(timestamp: event.timestamp,
- isolate: event.isolate, breakpoint: event.breakpoint,
- pauseBreakpoints: const <M.Breakpoint>[],
- topFrame: event.topFrame,
- atAsyncSuspension: event.atAsyncSuspension);
- break;
- case ServiceEvent.kPauseInterrupted:
- e = new PauseInterruptedEventMock(timestamp: event.timestamp,
- isolate: event.isolate, topFrame: event.topFrame,
- atAsyncSuspension: event.atAsyncSuspension);
- break;
- case ServiceEvent.kPauseException:
- // TODO(cbernaschina) add exception.
- e = new PauseExceptionEventMock(timestamp: event.timestamp,
- isolate: event.isolate, topFrame: event.topFrame);
- break;
- case ServiceEvent.kNone:
- e = new NoneEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kResume:
- e = new ResumeEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kBreakpointAdded:
- e = new BreakpointAddedEventMock(timestamp: event.timestamp,
- isolate: event.isolate, breakpoint: event.breakpoint);
- break;
- case ServiceEvent.kBreakpointResolved:
- e = new BreakpointResolvedEventMock(timestamp: event.timestamp,
- isolate: event.isolate, breakpoint: event.breakpoint);
- break;
- case ServiceEvent.kBreakpointRemoved:
- e = new BreakpointRemovedEventMock(timestamp: event.timestamp,
- isolate: event.isolate, breakpoint: event.breakpoint);
- break;
- case ServiceEvent.kGC:
- e = new GCEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kInspect:
- // TODO(cbernaschina) add inspectee: event.inspectee.
- e = new InspectEventMock(timestamp: event.timestamp,
- isolate: event.isolate);
- break;
- case ServiceEvent.kConnectionClosed:
- e = new ConnectionClockedEventMock(timestamp: event.timestamp,
- reason: event.reason);
- break;
- case ServiceEvent.kExtension:
- e = new ExtensionEventMock(timestamp: event.timestamp,
- isolate: event.isolate, extensionKind: event.extensionKind,
- extensionData: event.extensionData);
- break;
- }
- return new EventNotification(e);
- }
}
« no previous file with comments | « runtime/observatory/lib/src/app/event.dart ('k') | runtime/observatory/lib/src/app/page.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698